Atmosphere with Gizmos is broken

[mate-h]

Bevy version and features

• Bevy 0.18 on main branch
• sha e3814a944b5d14ae4313575f3c91d40f0fe9925e

What you did

Added the atmosphere to the 3d gizmo example.

mate-h@32f75cb

What went wrong

Bevy crashed on startup.

Additional information

2025-11-08T19:11:32.605689Z ERROR wgpu::backend::wgpu_core: Handling wgpu errors as fatal by default

thread '<unnamed>' panicked at /Users/mateh/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/wgpu-26.0.1/src/backend/wgpu_core.rs:2391:18:
wgpu error: Validation Error

Caused by:
  In a CommandEncoder
    In a draw command, kind: Draw
      The BindGroupLayout with 'mesh_view_layout_depth_deferred_atmosphere' label of current set BindGroup with 'mesh_view_bind_group' label at index 0 is not compatible with the corresponding BindGroupLayout with 'mesh_view_layout_depth_deferred' label of RenderPipeline with 'LineGizmo 3d Pipeline' label
        Assigned entry with binding 29 not found in expected bind group layout
        Assigned entry with binding 30 not found in expected bind group layout
        Assigned entry with binding 31 not found in expected bind group layout

[alice-i-cecile]

You've marked this as Ready-For-Implementation: what's the approximate fix?

[alice-i-cecile]

diff --git a/crates/bevy_gizmos_render/src/pipeline_3d.rs b/crates/bevy_gizmos_render/src/pipeline_3d.rs
index 854c3c7b4..e3e7964f9 100644
--- a/crates/bevy_gizmos_render/src/pipeline_3d.rs
+++ b/crates/bevy_gizmos_render/src/pipeline_3d.rs
@@ -21,7 +21,7 @@ use bevy_ecs::{
     system::{Commands, Query, Res, ResMut},
 };
 use bevy_image::BevyDefault as _;
-use bevy_pbr::{MeshPipeline, MeshPipelineKey, SetMeshViewBindGroup};
+use bevy_pbr::{ExtractedAtmosphere, MeshPipeline, MeshPipelineKey, SetMeshViewBindGroup};
 use bevy_render::{
     render_asset::{prepare_assets, RenderAssets},
     render_phase::{
@@ -290,6 +290,7 @@ fn queue_line_gizmos_3d(
             Has<MotionVectorPrepass>,
             Has<DeferredPrepass>,
             Has<OrderIndependentTransparencySettings>,
+            Has<ExtractedAtmosphere>,
         ),
     )>,
 ) {
@@ -303,7 +304,7 @@ fn queue_line_gizmos_3d(
         view,
         msaa,
         render_layers,
-        (normal_prepass, depth_prepass, motion_vector_prepass, deferred_prepass, oit),
+        (normal_prepass, depth_prepass, motion_vector_prepass, deferred_prepass, oit, atmosphere),
     ) in &views
     {
         let Some(transparent_phase) = transparent_render_phases.get_mut(&view.retained_view_entity)
@@ -336,6 +337,10 @@ fn queue_line_gizmos_3d(
             view_key |= MeshPipelineKey::OIT_ENABLED;
         }
 
+        if atmosphere {
+            view_key |= MeshPipelineKey::ATMOSPHERE;
+        }
+
         for (entity, main_entity, config) in &line_gizmos {
             if !config.render_layers.intersects(render_layers) {
                 continue;

There's a proposed fix from Discord, but I'm not equipped to fully evaluate it.