This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Add serialized descriptorprotos to python classes#56
Open
MichaelSchuldes wants to merge 1 commit intobetterproto:mainfrom
Open
Add serialized descriptorprotos to python classes#56MichaelSchuldes wants to merge 1 commit intobetterproto:mainfrom
MichaelSchuldes wants to merge 1 commit intobetterproto:mainfrom
Conversation
MichaelSchuldes
force-pushed
the
descriptors_in_python_class
branch
from
ab50cbf to
09b978e
Compare
MichaelSchuldes
force-pushed
the
descriptors_in_python_class
branch
from
09b978e to
473f71f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a staticmethod
_serialized_pbto the generated enums and message classes that returns the serialized DescriptorProto. From that string it is possible to generate die Proto Descriptors, which are needed if you want to write the OSI messages in an MCAP file using mcap-protobuf-supportSee this issue for the necessary parts to set the DESCRIPTOR at runtime in python-betterproto2 python-betterproto2/issues/70.
Checklist