Skip to content

Conversation

@rickeylev
Copy link
Collaborator

With the py_proto_library rules removed from rules_python, rules_python is no
longer the appropriate place to have examples for using the py_proto_library
rules. Having such example also causes some maintenance burden, as apparently
it incurs a nodejs dependency, which fails under newer bazel versions.

Fixes #3362

@rickeylev rickeylev requested a review from aignas as a code owner January 12, 2026 00:48
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the bzlmod example by completely removing the py_proto_library examples. This change is necessary because the py_proto_library rules are no longer part of rules_python, and maintaining these examples introduced unnecessary complexity and compatibility issues, particularly with nodejs dependencies and newer Bazel versions. The removal simplifies the example set and reduces maintenance overhead.

Highlights

  • Removal of py_proto_library examples: The entire py_proto_library example directory within examples/bzlmod has been removed, including all associated BUILD files, proto definitions, and Python test scripts.
  • Dependency Cleanup: Associated Bazel module dependencies, such as protobuf and foo_external, along with their local path overrides, have been removed from examples/bzlmod/MODULE.bazel.
  • Maintenance Burden Reduction: This change addresses and resolves maintenance issues previously caused by these examples, specifically a nodejs dependency and compatibility problems with newer Bazel versions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the py_proto_library example from the bzlmod examples. This is a necessary cleanup since the py_proto_library rules have been removed from rules_python. The changes are comprehensive, including the deletion of all related example files and directories, as well as the removal of corresponding dependencies from MODULE.bazel and entries from .bazelignore. The changes are clean and appear to be complete. I have no specific comments on the code changes as they correctly implement the intended removal.

@rickeylev rickeylev enabled auto-merge January 12, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bazel CI] invalid registered toolchain '@nodejs_toolchains//:all': while parsing '@nodejs_toolchains//:all': error loading package

1 participant