Skip to content

Remove calls to PHP 8.5-deprecated setAccessible #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barryvdh merged 1 commit into from
Dec 10, 2025
+0 −8
Merged

Remove calls to PHP 8.5-deprecated setAccessible #1744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion php-templates/translations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ function vscodeCollectTranslations(string $path, ?string $namespace = null)
$property = $reflection->hasProperty('paths')
? $reflection->getProperty('paths')
: $reflection->getProperty('path');
$property->setAccessible(true);

$paths = Illuminate\Support\Arr::wrap($property->getValue($loader));

Expand Down
6 changes: 0 additions & 6 deletions src/Console/ModelsCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,6 @@ protected function isRelationNullable(string $relation, Relation $relationObj):

if (in_array($relation, ['hasOne', 'hasOneThrough', 'morphOne'], true)) {
$defaultProp = $reflectionObj->getProperty('withDefault');
$defaultProp->setAccessible(true);

return !$defaultProp->getValue($relationObj);
}
Expand All @@ -897,7 +896,6 @@ protected function isRelationNullable(string $relation, Relation $relationObj):
}

$fkProp = $reflectionObj->getProperty('foreignKey');
$fkProp->setAccessible(true);

$enforceNullableRelation = $this->laravel['config']->get('ide-helper.enforce_nullable_relationships', true);

Expand Down Expand Up @@ -930,7 +928,6 @@ protected function isMorphToRelationNullable(Relation $relationObj): bool
}

$fkProp = $reflectionObj->getProperty('foreignKey');
$fkProp->setAccessible(true);

foreach (Arr::wrap($fkProp->getValue($relationObj)) as $foreignKey) {
if (isset($this->nullableColumns[$foreignKey])) {
Expand Down Expand Up @@ -1283,9 +1280,6 @@ protected function hasCamelCaseModelProperties()
*/
protected function getAttributeTypes(Model $model, \ReflectionMethod $reflectionMethod): Collection
{
// Private/protected ReflectionMethods require setAccessible prior to PHP 8.1
$reflectionMethod->setAccessible(true);

/** @var Attribute $attribute */
$attribute = $reflectionMethod->invoke($model);

Expand Down
1 change: 0 additions & 1 deletion src/Factories.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ public static function all()
$factory = app(Factory::class);

$definitions = (new ReflectionClass(Factory::class))->getProperty('definitions');
$definitions->setAccessible(true);

foreach ($definitions->getValue($factory) as $factory_target => $config) {
try {
Expand Down
Loading