fix resources parameter to accept just cpu and/or memory#377
Open
nickdallavalentina wants to merge 1 commit intoawslabs:mainfrom
Open
fix resources parameter to accept just cpu and/or memory#377nickdallavalentina wants to merge 1 commit intoawslabs:mainfrom
nickdallavalentina wants to merge 1 commit intoawslabs:mainfrom
Conversation
Contributor
|
There are other resource types (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
There is no validation on the parameter that are passed to
-resourcesthen you can pass whatever parameter,example how to replicate:
eks-node-viewer -resources memoriesDescription of changes:
This change adds validation for the -resources flag to ensure that only the values "cpu" and/or "memory" are accepted. If any invalid resource is provided (e.g., "memoryss"), the application will return an error. The update includes a helper function to validate the comma-separated list of resources