Skip to content

add npm publish example #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andimarek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add npm publish example #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,12 @@ jobs:
env:
GITHUB_MAVEN_USERNAME: ${{ secrets.GITHUB_MAVEN_USERNAME }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
MAVEN_RELEASES_URL: https://maven.pkg.github.com/atlassian/packages-maven
Copy link
Contributor

@Malinskiy Malinskiy Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need MAVEN_RELEASES_URL anymore since umbrella-type repos do not works for our purpose

test-npm:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: deploy-release
run: npm publish
env:
NPM_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.DS_STORE
1 change: 1 addition & 0 deletions npm-example/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
console.log('hello world');
23 changes: 23 additions & 0 deletions npm-example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"name": "github-packages-test",
Copy link
Contributor

@Malinskiy Malinskiy Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Packages only supports scoped npm packages. Scoped packages have names with the format of @owner/name

Probably should be @atlassian/github-packages-test

"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"repository": {
"type": "git",
"url": "git+https://github.com/atlassian/github-packages-test.git"
Copy link
Contributor

@Malinskiy Malinskiy Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to docs probably should be only git. Not sure if git+https will work

},
"publishConfig": {
"registry":"https://npm.pkg.github.com/"
},
"keywords": [],
"author": "",
"license": "ISC",
"bugs": {
"url": "https://github.com/atlassian/github-packages-test/issues"
},
"homepage": "https://github.com/atlassian/github-packages-test#readme"
}