Skip to content

AXON-1642 - Change to ensure compatibility across OS's & Shells #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bwieger-atlassian-com wants to merge 7 commits into
base: main
Choose a base branch
from
Open

AXON-1642 - Change to ensure compatibility across OS's & Shells #1290

bwieger-atlassian-com wants to merge 7 commits into from
+18 −1

Conversation

@bwieger-atlassian-com
Copy link
Collaborator

@bwieger-atlassian-com bwieger-atlassian-com commented Nov 14, 2025 •
edited
Loading

What Is This Change?

  • Issue Rovo Dev agent crashes on new chat #1289
  • Some linux folks are reporting issues with the executable running.
  • I was NOT able to repro
  • However, the leading hypothesis is that some of the env vars needed to run in linux are not being passed.
  • Also, I enriched the error messaging for executable not found / access denied

Comms to users: #1289 (comment)

How Has This Been Tested?

  • Checked on Mac
  • Checked on Linux (via WSL)
  • Checked on Windows

@bwieger-atlassian-com bwieger-atlassian-com marked this pull request as ready for review December 5, 2025 19:51
atlassian[bot]
atlassian bot reviewed Dec 5, 2025
View reviewed changes
src/rovo-dev/rovoDevProcessManager.ts
);
} else {
reject(
new Error(`Cannot access executable: ${err.message}${err.code ? ` (${err.code})` : ''}`),
Copy link
Contributor

@atlassian atlassian bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔎 Code Readability

Add a space before the opening parenthesis for consistency: ${err.message}${err.code ? (${err.code}) : ''} should be ${err.message}${err.code ? (${err.code}) : ''}.

@bwieger-atlassian-com bwieger-atlassian-com changed the title Change to ensure compatibility across OS's AXON-1642 - Change to ensure compatibility across OS's Dec 5, 2025
@bwieger-atlassian-com bwieger-atlassian-com changed the title AXON-1642 - Change to ensure compatibility across OS's AXON-1642 - Change to ensure compatibility across OS's & Shells Dec 5, 2025
@bwieger-atlassian-com bwieger-atlassian-com mentioned this pull request Dec 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atlassian atlassian[bot] atlassian[bot] left review comments

@sdzh-atlassian sdzh-atlassian Awaiting requested review from sdzh-atlassian sdzh-atlassian is a code owner

@cabella-dot cabella-dot Awaiting requested review from cabella-dot cabella-dot is a code owner

@marcomura marcomura Awaiting requested review from marcomura marcomura is a code owner

@jwang19-atlassian jwang19-atlassian Awaiting requested review from jwang19-atlassian jwang19-atlassian is a code owner

@teg-atlassian teg-atlassian Awaiting requested review from teg-atlassian teg-atlassian is a code owner

@bhorai-atl bhorai-atl Awaiting requested review from bhorai-atl bhorai-atl is a code owner

@om-ukr om-ukr Awaiting requested review from om-ukr om-ukr is a code owner

@sspanchenko sspanchenko Awaiting requested review from sspanchenko sspanchenko is a code owner

@Blastoplex Blastoplex Awaiting requested review from Blastoplex Blastoplex is a code owner

@matt-lassian matt-lassian Awaiting requested review from matt-lassian matt-lassian is a code owner

@dchiew-atl dchiew-atl Awaiting requested review from dchiew-atl dchiew-atl is a code owner

@amarg-at amarg-at Awaiting requested review from amarg-at amarg-at is a code owner

@ccallcottstevens ccallcottstevens Awaiting requested review from ccallcottstevens ccallcottstevens is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bwieger-atlassian-com