Skip to content

Improve test coverage #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JulianVennen merged 3 commits into from
Apr 8, 2025
Merged

Improve test coverage #15

JulianVennen merged 3 commits into from
Apr 8, 2025

Conversation

@JulianVennen
Copy link
Member

@JulianVennen JulianVennen commented Apr 8, 2025

  • Cover getters/setters of AbstractLock with tests
  • Cover EtcdStorage with tests
  • Update PHPUnit
  • Reorder some getters/setters to match the property order
  • Make returnNewValueOnFail optional in StorageInterface->putIf() to match deleteIf()

@JulianVennen JulianVennen requested a review from matthi4s April 8, 2025 07:56
@JulianVennen JulianVennen merged commit 136b0df into master Apr 8, 2025
5 checks passed
@JulianVennen JulianVennen deleted the tests branch April 8, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthi4s matthi4s matthi4s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JulianVennen @matthi4s