Skip to content

Conversation

@Wreck7
Copy link

@Wreck7 Wreck7 commented Dec 10, 2025

What I Fixed

Updated the font size in the Hero banner section to improve readability and clarity.

Ensures the text/icon backed by "Users" is now clearly visible.

Why This Fix Was Needed

The original font size was big, making the text/icon in the Hero banner unclear.

Screenshots

Before
image

After
image

Linked Issue

Closes #256

@vercel
Copy link

vercel bot commented Dec 10, 2025

@Wreck7 is attempting to deploy a commit to the AJEET PRATAP SINGH's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Walkthrough

This pull request makes two minimal changes: adjusts the Hero section heading font size from 6rem to 5.8rem on large viewports, and updates the TypeScript JSX compiler option from "preserve" to "react-jsx". These address UI proportions and configure the JSX transformation runtime.

Changes

Cohort / File(s) Summary
Hero component styling
apps/web/src/components/landing-sections/Hero.tsx
Reduced h1 font size breakpoint on large screens from lg:text-[6rem] to lg:text-[5.8rem]
TypeScript configuration
apps/web/tsconfig.json
Updated JSX compiler option from "preserve" to "react-jsx" to use the modern JSX transform

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify the tsconfig.json JSX option change doesn't introduce unexpected build or runtime behavior
  • Confirm the 0.2rem font reduction visually addresses the banner proportions issue in #256

Possibly related PRs

Poem

🐰 A banner stands a touch less tall,
JSX transforms with a config call,
Five-point-eight rems fit just right,
The hero shines in clearer sight!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The tsconfig.json JSX runtime change from 'preserve' to 'react-jsx' appears unrelated to the linked issue #256, which focuses on hero banner UI visibility and height adjustments. Remove the tsconfig.json JSX runtime change or provide justification linking it to the hero banner visibility issue in #256.
Linked Issues check ❓ Inconclusive The Hero banner font size adjustment addresses making 'backed by Users' more visible. However, the linked issue also mentions fixing hero banner height to fit the screen, which is not addressed by the font size change alone. Clarify whether the font size reduction alone resolves the height/visibility issue or if additional height-related changes are needed to fully address issue #256.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed Title focuses on font size adjustment in Hero banner, which aligns with the main code change (h1 font size reduction from lg:text-[6rem] to lg:text-[5.8rem]), though the tsconfig.json JSX runtime change is unmentioned.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cla-assistant
Copy link

cla-assistant bot commented Dec 10, 2025

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Dec 10, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix UI (minor): hero banner height

1 participant