feat: SDK update for version 25.2.0#130
Conversation
Greptile SummaryThis SDK update to v25.2.0 adds JWT authentication for Realtime WebSocket connections, forwards
Confidence Score: 3/5Both headline features are silently non-functional due to config key casing mismatches; existing non-impersonated API surface is unaffected. JWT auth on Realtime sockets and impersonateUserId forwarding each fail because the config map is read with a different key casing than the one used when storing the value, making both advertised additions dead code at runtime. Realtime.kt (JWT lookup), Avatars.kt and Storage.kt (impersonateUserId lookup), and Client.kt (source-of-truth for stored key names). Important Files Changed
Reviews (3): Last reviewed commit: "chore: update Android SDK to 25.2.0" | Re-trigger Greptile |
| "password", // password | ||
| "password", // oldPassword (optional) |
There was a problem hiding this comment.
Both password fields show the same literal value
After this change both password and oldPassword are set to the plain string "password". The previous oldPassword = "<OLD_PASSWORD>" placeholder made the distinction between the two arguments visually obvious. Using identical string literals here makes it easy for a reader to copy the snippet and inadvertently pass the same value for both, which the server will accept as a valid (though semantically wrong) request. Consider using distinct placeholder strings — e.g. "newPassword" / "oldPassword" — to communicate intent.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This PR contains updates to the SDK for version 25.2.0.
What's Changed
x-appwrite-jwtheader for authentication.impersonateUserIdonavatarsandstoragefile requests.