Skip to content

Conversation

@aldaris
Copy link
Contributor

@aldaris aldaris commented Nov 28, 2024

This PR attempts to address most of the deprecated call warnings shown during compilation time. There are a still couple of them left that are a bit more tricky to handle:

  • DebugSettings#isOutputMarkupContainerClassName usage in Page - the output strategy is not simple to implement given that Page currently only embeds the classname as a separate comment element, not sure what it should tie to otherwise
  • Cookie#setComment, #setVersion usages - don't think anything really needs to be done about these
  • CachingResourceStreamLocator#locate - there is a missing @deprecated annotation. Without proper JavaDoc explanation I didn't want to go down a road for this one
  • AccessController usages in JavaSerializer - could just replace them with Runnable#run I suppose, but wasn't sure whether security manager support was there for something specific

Copy link
Contributor

@bitstorm bitstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! Do you have a JIRA account to create a related issue?

@bitstorm bitstorm changed the title Work on deprecation warnings WICKET-7135 Work on deprecation warnings Dec 2, 2024
@bitstorm bitstorm merged commit da01909 into apache:master Dec 2, 2024
2 checks passed
bitstorm pushed a commit that referenced this pull request Dec 2, 2024
* Migrate new Locale constructor invocations to Locale.of calls

* Migrate new URL constructor invocations to URI#toURL

* Migrate deprecated API calls to their replacements
bitstorm added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants