doc: clarify run-plugin argument is fixed at load time#13429
Open
maskit wants to merge 1 commit into
Open
Conversation
The run-plugin action's plugin-argument is parsed once when the
rule loads, like a remap.config argument, and is never
re-evaluated per request, so variable interpolation (e.g.
%{HEADER:bar}) does not work there.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR clarifies the run-plugin directive behavior in the header_rewrite admin guide by documenting that the "<plugin-argument> ..." string is parsed once at rule load/reload time (similar to remap.config) and is not re-evaluated per request, so variable interpolation does not apply.
Changes:
- Add a documentation note under
run-pluginexplaining that<plugin-argument>is fixed at load/reload time. - Explicitly state that per-request variable interpolation (e.g.
%{HEADER:bar}) does not work inrun-pluginarguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run-plugin action's plugin-argument is parsed once when the rule loads, like a remap.config argument, and is never re-evaluated per request, so variable interpolation (e.g. %{HEADER:bar}) does not work there.