Partial Java 25 support for TinkerPop 3.8.x#3488
Open
porunov wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.8-dev #3488 +/- ##
==========================================
Coverage ? 76.47%
Complexity ? 14906
==========================================
Files ? 1160
Lines ? 72214
Branches ? 8070
==========================================
Hits ? 55226
Misses ? 14055
Partials ? 2933 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Update Groovy to 4.0.32 (which bundles a version of ASM that can parse Java 25 class files) and make the other changes required to build, test, and run TinkerPop on Java 25: - pom.xml: bump groovy.version to 4.0.32 and widen the enforcer requireJavaVersion range to [11,26) - StringFactory: detect the Java 21+ lambda class name format ($$Lambda/0x...) so a step's toString() renders "lambda" consistently - LambdaRestrictionStrategy: match "lambda" case-insensitively - gremlin-groovy and gremlin-archetype-dsl: declare annotationProcessorPaths explicitly because, as of JDK 23, javac no longer runs annotation processors that are only discovered on the classpath (GremlinDslProcessor) - gremlin-groovy: activate the javadoc groovy-stubs sourcepath profile for all JDK 11 and newer instead of only 11-17 - gremlin-console: apply the neo4j-gremlin --add-opens flags for JDK 17+ - ImportGremlinPluginTest: account for Math.TAU added in Java 19 - build-test.yml: add a Java 25 build job Also bump Hadoop to 3.4.3 so hadoop-gremlin builds and runs on Java 25. Hadoop 3.3.3 fails on Java 25 because UserGroupInformation calls Subject.getSubject(), which throws UnsupportedOperationException now that the Security Manager has been removed. Hadoop 3.4.3 migrated to the replacement APIs (HADOOP-19212): - pom.xml: hadoop.version 3.3.3 -> 3.4.3; kerby.version 2.0.1 -> 2.0.3 to match the Kerby version Hadoop 3.4.3 ships; pin wildfly-common (pulled in transitively by the Kerby test KDC) to satisfy dependency convergence - gremlin-test: exclude jline from kerb-simplekdc (only used by the unused kadmin CLI) to avoid a clash with the jline from Hadoop's yarn client - hadoop-gremlin: bump nimbus-jose-jwt to 9.30.1 to match Kerby 2.0.3 - spark-gremlin: align Netty (via netty-bom) and metrics-core and bump curator-recipes, since Spark 3.3.2 and Hadoop 3.4.3 ship different versions of these - build-test.yml: include hadoop-gremlin in the Java 25 job; only spark-gremlin remains excluded spark-gremlin stays on Spark 3.3.2 and is built and tested with Java 11 and 17 only. The only Spark releases that support Java 25 (4.1+) require Java 17 as a minimum and Scala 2.13, which would drop Java 11 support for the module. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksandr Porunov <alexandr.porunov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add partial support for building and running with Java 25.
All modules except
spark-gremlinbecome compatible with Java 25.This may potentially help graph providers that don't use
spark-gremlinto upgrade to Java 25.Providers that do require
spark-gremlinwill not be able to upgrade to Java 25 on TinkerPop 3.x versions. Full Java 25 upgrade requires dropping Java 11 support. You can find full Java 25 upgrade in PR #3489 which targets TinkerPop 4.0.0.The reason Spark can't be upgraded to the newer version on
3.8-devbranch is because there are no Spark versions available that are compatible with both Java 11 and Java 25. New Spark versions require minimum Java 17.There was the first attempt to add Java 25 support in the PR #3283
This PR can be considered as continuation