[SPARK-57809][SQL] Support nanosecond-precision timestamps in collect_list/listagg ordering safety#56946
Open
iRakson wants to merge 1 commit into
Open
[SPARK-57809][SQL] Support nanosecond-precision timestamps in collect_list/listagg ordering safety#56946iRakson wants to merge 1 commit into
iRakson wants to merge 1 commit into
Conversation
…_list/listagg ordering safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add nanosecond arms so the ORDER BY-cast optimization applies to NTZ nanos and correctly excludes LTZ nanos, matching the microsecond behavior.
Why are the changes needed?
collect.scala isCastEqualityPreserving (~L750-762) marks TimestampNTZType as cast-equality-preserving and TimestampType (LTZ, DST) as unsafe, but has no arm for TimestampNTZNanosType / TimestampLTZNanosType, so both fall to case _ => false. NTZ nanos should be treated like NTZ micro (safe); LTZ nanos like LTZ micro.
Does this PR introduce any user-facing change?
Yes, nanosecond precision timestamps behaviour would be same as microsecond timestamp behaviour now.
How was this patch tested?
Added UT.
Was this patch authored or co-authored using generative AI tooling?
Claude for writing UT.