[SPARK-57846][SQL] Add the try_make_time function#56932
Open
yadavay-amzn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds the
try_make_time(hour, minute, second)function, the error-safe counterpart tomake_time: it returns the same result on valid input andNULL(instead of throwing) on invalid input. It is implemented asTryEval(MakeTime(...)), mirroringtry_make_timestamp. Registered in the function registry, exposed viafunctions.scala, and documented (ANSI-compliance try-functions list +sql-expression-schema).Why are the changes needed?
make_timethrows on invalid components (e.g.hour = 25). Users want a null-returning variant consistent with the othertry_*datetime constructors (try_make_timestamp, etc.).Does this PR introduce any user-facing change?
Yes - a new function
try_make_time.How was this patch tested?
Unit tests (
TimeExpressionsSuite), integration (TimeFunctionsSuiteBase), SQL-level (time.sql), and Connect plan-generation goldens: valid input equalsmake_time, invalid input returnsNULL.Was this patch authored or co-authored using generative AI tooling?
Authored with assistance by Claude Opus 4.8.