Skip to content

[MINOR] Remove branch-4.x "build_main.yml" icon in README#56915

Closed
gaogaotiantian wants to merge 2 commits into
apache:masterfrom
gaogaotiantian:remove-4.x-main-icon
Closed

[MINOR] Remove branch-4.x "build_main.yml" icon in README#56915
gaogaotiantian wants to merge 2 commits into
apache:masterfrom
gaogaotiantian:remove-4.x-main-icon

Conversation

@gaogaotiantian

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

The branch-4.x "build" icon is removed from README.md

Why are the changes needed?

We don't run post-merge CIs on branch-4.x anymore so that data is just stale.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Checked icon on branch.

Was this patch authored or co-authored using generative AI tooling?

No.

Comment thread README.md
| | [![GitHub Actions Build](https://github.com/apache/spark/actions/workflows/build_python_connect40.yml/badge.svg)](https://github.com/apache/spark/actions/workflows/build_python_connect40.yml) |
| | [![GitHub Actions Build](https://github.com/apache/spark/actions/workflows/build_python_connect.yml/badge.svg)](https://github.com/apache/spark/actions/workflows/build_python_connect.yml) |
| | [![GitHub Actions Build](https://github.com/apache/spark/actions/workflows/build_sparkr_window.yml/badge.svg)](https://github.com/apache/spark/actions/workflows/build_sparkr_window.yml) |
| branch-4.x | [![GitHub Actions Build](https://github.com/apache/spark/actions/workflows/build_main.yml/badge.svg?branch=branch-4.x)](https://github.com/apache/spark/actions/workflows/build_main.yml?query=branch%3Abranch-4.x) |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only removes build_main.yaml while keeping other branch-4.x build icon, doesn't it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current PR title sounds a little misleading.

[MINOR] Remove branch-4.x "build" icon in README

@gaogaotiantian gaogaotiantian Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the title. The icon shows "Build" because the workflow name of build_main.yml is Build. Yes, only that icon is removed.

@gaogaotiantian gaogaotiantian changed the title [MINOR] Remove branch-4.x "build" icon in README [MINOR] Remove branch-4.x "build_main" icon in README Jun 30, 2026
@gaogaotiantian gaogaotiantian changed the title [MINOR] Remove branch-4.x "build_main" icon in README [MINOR] Remove branch-4.x "build_main.yml" icon in README Jun 30, 2026

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you!

@gaogaotiantian

Copy link
Copy Markdown
Contributor Author

Merged to master, thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants