Evaluate upgrading Groovy to 5.0.0 under JDK 11 runtime constraint #13679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Groovy dependency from version 4.0.15 to 5.0.0, with a focus on validating runtime compatibility under JDK 11 constraints. The author has verified that the OAP distribution builds successfully with JDK 21 and runs on JDK 11 without compatibility issues.
Changes:
- Upgrade Groovy version from 4.0.15 to 5.0.0 in the BOM
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
e2e and UT seem all good. Could you fix dependency and change log? |
wu-sheng
added
backend
wu-sheng
reviewed
Jan 21, 2026
| <javaassist.version>3.25.0-GA</javaassist.version> | ||
| <vavr.version>0.10.3</vavr.version> | ||
| <groovy.version>4.0.15</groovy.version> | ||
| <groovy.version>5.0.0</groovy.version> |
Member
There was a problem hiding this comment.
Suggested change
| <groovy.version>5.0.0</groovy.version> | |
| <groovy.version>5.0.3</groovy.version> |
We should consider latest patch version. Ref to https://mvnrepository.com/artifact/org.apache.groovy/groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluation Purpose
This PR is an extension to another PR ( #13671 ) and evaluates upgrading the Groovy engine from 4.0.x to 5.0.0 (earliest GA) with a focus on validating SkyWalking’s JDK 11 runtime compatibility guarantee.
Groovy is used as a runtime dependency in several OAP backend modules, so this change is evaluated strictly from a compatibility and policy perspective.
Verification Results
Local evaluation was performed using JDK 21 for build and JDK 11 for runtime, targeting the primary Groovy consumers (
log-analyzerandmeter-analyzer).Build Status: SUCCESS (built with JDK 21)
Runtime Compatibility:
Verified that the OAP distribution starts successfully on JDK 11 with Groovy 5.0.0.
-Pdist) on JDK 21, then launched OAP viaoapService.batusing JDK 11.UnsupportedClassVersionErroror JVM compatibility failures.Tests Passed:
oap-server/analyzer/log-analyzer(LAL script parsing)oap-server/analyzer/meter-analyzer(MAL script execution)Key Findings
Scope Notes
This PR is intended solely as a compatibility evaluation and does not include test refactors, additional Groovy 5.x upgrades, or behavioral changes.