Skip to content

Conversation

@wankai123
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wankai123 wankai123 added this to the 10.4.0 milestone Jan 20, 2026
@wankai123 wankai123 requested review from Copilot and wu-sheng January 20, 2026 03:05
@wankai123 wankai123 added the enhancement Enhancement on performance or codes label Jan 20, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the labeled metrics query functionality in MQE by replacing the basic split() method with Guava's Splitter API, which automatically trims whitespace and omits empty strings from the parsed label values. This improves query robustness and readability by handling label value inputs more gracefully.

Changes:

  • Replaced String.split() with Splitter.on(separator).omitEmptyStrings().trimResults() in the buildLabelIndex method
  • Added necessary Guava imports (Splitter and Iterables)
  • Updated CHANGES.md to document the enhancement

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetricsQueryDAO.java Enhanced label value parsing to trim whitespace and filter empty strings using Guava Splitter
docs/en/changes/changes.md Added changelog entry describing the enhancement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wankai123 wankai123 merged commit 95c03d5 into apache:master Jan 20, 2026
526 of 531 checks passed
@wankai123 wankai123 deleted the mqe-label-values branch January 20, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement on performance or codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants