RANGER-5447: update local policy source implementations to support loading from serviceName.json #802
+476
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ading from serviceName.json
mneethiraj
requested review from
Copilot,
kumaab,
pradeepagrawal8184,
rameeshm,
spolavarpau1 and
vperiasamy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances local policy source implementations to support loading policies from both <serviceName>.json and <appId>_<serviceName>.json file naming patterns. This provides more flexible configuration options for different deployment scenarios.
Changes:
- Introduced a new abstract class
RangerPolicySourceto consolidate common file suffix definitions and unimplemented methods - Updated
LocalFolderPolicySourceandEmbeddedResourcePolicySourceto try loading from<serviceName>prefix first, falling back to<appId>_<serviceName>prefix if needed - Added comprehensive unit tests for both implementations covering all loading scenarios
Reviewed changes
Copilot reviewed 15 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| agents-common/src/main/java/org/apache/ranger/admin/client/RangerPolicySource.java | New abstract base class defining file suffix constants and stub methods for policy source implementations |
| agents-common/src/main/java/org/apache/ranger/admin/client/LocalFolderPolicySource.java | Updated to support dual prefix loading (serviceName and appId_serviceName) with fallback logic |
| agents-common/src/main/java/org/apache/ranger/admin/client/EmbeddedResourcePolicySource.java | Updated to support dual prefix loading for embedded resources with improved error handling |
| agents-common/src/test/java/org/apache/ranger/admin/client/TestLocalFolderPolicySource.java | New test class covering serviceName prefix, appId_serviceName prefix, and error scenarios |
| agents-common/src/test/java/org/apache/ranger/admin/client/TestEmbeddedResourcePolicySource.java | New test class with equivalent coverage for embedded resource loading |
| agents-common/src/test/resources/admin.client/*.json | Test resource files for both serviceName and appId_serviceName naming patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
updated local policy source implementations to support loading from
<serviceName>.jsonand<appId>_<serviceName>.json.How was this patch tested?
updated unit tests to cover loading from both locations.