chore(devcontainer): update toolchain to project requirements#3563
Merged
PragmaTwice merged 3 commits intoJul 23, 2026
Conversation
PragmaTwice
reviewed
Jul 21, 2026
PragmaTwice
reviewed
Jul 21, 2026
| && cd /opt/minica && git checkout 96a5c93723cf3d34b50b3e723a9f05cd3765bc67 && go build && cd $BUILD_DIR \ | ||
| && echo 'export PATH=/opt/minica:$PATH' >> $HOME/.bashrc | ||
|
|
||
| ENV LDFLAGS="-latomic" |
Contributor
Author
There was a problem hiding this comment.
You're right — it isn't needed for the default GCC build. It was added after testing an explicit Clang build, so I've removed the global LDFLAGS. A clean GCC 15 build and the tests pass without it.
maoyouaa
marked this pull request as ready for review
July 23, 2026 08:20
PragmaTwice
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The existing development container no longer matches the repository requirements. Ubuntu Noble provides Go 1.22 while the Go test module requires Go 1.25, and the container pins Clang Format/Tidy 14 while
x.pyrequires version 18 or newer.Impact
Fresh development containers provide the required Go and LLVM tooling, and the default format and tidy commands work without additional path arguments.
Validation
docker buildof.devcontainer/Dockerfile./x.py build build --unittest --ninja -j 12./x.py test cpp build(600 passed, 1 skipped)./x.py test go build -run TestPing./x.py format./x.py check format./x.py check tidy build -j 12git diff --checkPrepared with assistance from OpenAI Codex and verified locally.