[Improvement] Use bounded thread pool in SessionPoolExample to avoid potential OOM (#17016) #17019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #17016.
As discussed in the issue, the
SessionPoolExamplecurrently usesExecutors.newFixedThreadPool(10), which internally employs an unboundedLinkedBlockingQueue. This can lead toOutOfMemoryErrorin high-throughput scenarios if users copy this example code into production.This PR replaces it with a
ThreadPoolExecutorusing a boundedArrayBlockingQueueto provide backpressure and ensure system stability.Related Issue
Fixes #17016
Type of changes
Checklist: