fix(glue): apply catalog properties when loading metadata#1487
Open
fallintoplace wants to merge 1 commit into
Open
fix(glue): apply catalog properties when loading metadata#1487fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Glue loaded table metadata with a nil property map in both registration and normal table loading. Filesystem implementations that depend on catalog configuration could therefore fail even though the catalog was configured correctly.
Changes
Pass the Glue catalog properties to the filesystem factory used by
RegisterTableandconvertGlueToIceberg.Testing
Added a property-dependent custom filesystem and exercised both registration and normal loading.
go test ./catalog/glue