HBASE-29797 Should not create wal directory when creating WAL instance

[Apache9]

No description provided.

[Apache9]

The fix is simple, but the most challenging thing is how to make existing tests pass, without modifying too much code.

Let's see the pre commit result, I believe there will still be some failures...

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 54s		master passed
+1 💚	compile	8m 20s		master passed
+1 💚	checkstyle	2m 14s		master passed
+1 💚	spotbugs	8m 51s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	compile	8m 13s		the patch passed
+1 💚	javac	8m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 13s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	9m 22s		the patch passed
+1 💚	hadoopcheck	11m 12s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		66m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7585
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname	Linux d8522cb9ebc2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 76c4ce4
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	191 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 15s		master passed
+1 💚	compile	2m 7s		master passed
+1 💚	javadoc	2m 21s		master passed
+1 💚	shadedjars	5m 57s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	2m 2s		the patch passed
+1 💚	javac	2m 2s		the patch passed
+1 💚	javadoc	2m 20s		the patch passed
+1 💚	shadedjars	5m 54s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	224m 56s	/patch-unit-root.txt	root in the patch failed.
		259m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7585
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 69431e2989eb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 76c4ce4
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/3/testReport/
Max. process+thread count	4742 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Umeshkumar9414]

LGTM

[Umeshkumar9414]

I thought tests are passing. But looks like there are many yet to fix.