HBASE-29796 [branch-2] Allow sleepForRetry replication config to be overridden by replication peers #7578

sidkhillon · 2025-12-26T17:36:14Z

Currently, sleepForRetries (the sleep time between retry attempts during replication) is only configurable globally via the replication.source.sleepforretries configuration property. This makes it impossible to tune behavior for individual replication peers that may have different requirements.

This change would add support for overriding replication source config values on a per-peer basis, with fallback to the global configuration when not set.

This is related to #7577 and was created because that PR will not cleanly merge into branch-2

Add support for configuring sleepForRetries on a per-peer basis with automatic fallback to global configuration when not set. Changes: - Add optional int64 sleep_for_retries field (13) to ReplicationPeer protobuf - Field 12 reserved for remoteWALDir (future version compatibility) - Add getSleepForRetries/setSleepForRetries to ReplicationPeerConfig/Builder - Update ReplicationSource, ReplicationSourceWALReader, ReplicationSourceShipper to check peer config first, then fall back to global config - Add set_peer_sleep_for_retries shell command - Add Sleep For Retries column to Master UI Peers table - Add tests to ReplicationPeerConfigTestUtil and replication_admin_test.rb Behavior: - Value > 0: Uses per-peer configured sleep time - Value = 0 or not set: Falls back to global replication.source.sleepforretries config (default 1000ms) Backward compatible: Optional protobuf field, old/new clients interoperate

sidkhillon · 2025-12-26T17:37:54Z

hbase-protocol-shaded/src/main/protobuf/Replication.proto

+  optional string remoteWALDir = 12;
+  optional int64 sleep_for_retries = 13;


I am unsure of the intended approach here. In #7577, we add sleep_for_retries as field 13. However, remoteWALDir does not exist in branch-2. I have added it here as a dummy value so that upgrades from branch-2 to branch-3 can be done seamlessly. If that is not the right approach, I'm happy to change it.

Apache-HBase · 2025-12-31T07:53:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 40s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 31s		branch-2 passed
+1 💚	compile	1m 27s		branch-2 passed
+1 💚	javadoc	0m 48s		branch-2 passed
+1 💚	shadedjars	4m 36s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 9s		the patch passed
+1 💚	compile	1m 26s		the patch passed
+1 💚	javac	1m 26s		the patch passed
+1 💚	javadoc	0m 46s		the patch passed
+1 💚	shadedjars	4m 33s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 23s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	7m 41s		hbase-client in the patch passed.
-1 ❌	unit	7m 15s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	6m 40s		hbase-shell in the patch passed.
		44m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7578
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 7a32aa0eb4e4 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a50259f`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/testReport/
Max. process+thread count	1478 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-31T08:00:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 8s		branch-2 passed
+1 💚	compile	4m 44s		branch-2 passed
+1 💚	checkstyle	1m 10s		branch-2 passed
+1 💚	spotbugs	4m 17s		branch-2 passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 11s		the patch passed
+1 💚	compile	4m 43s		the patch passed
+1 💚	cc	4m 43s		the patch passed
+1 💚	javac	4m 43s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 10s		the patch passed
-0 ⚠️	rubocop	0m 9s	/results-rubocop.txt	The patch generated 3 new + 484 unchanged - 0 fixed = 487 total (was 484)
+1 💚	spotbugs	4m 40s		the patch passed
+1 💚	hadoopcheck	16m 59s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚	hbaseprotoc	1m 41s		the patch passed
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		51m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7578
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc rubocop
uname	Linux 173294ee171b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a50259f`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-31T11:27:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 28s		branch-2 passed
+1 💚	compile	2m 8s		branch-2 passed
+1 💚	javadoc	1m 7s		branch-2 passed
+1 💚	shadedjars	6m 33s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	2m 15s		the patch passed
+1 💚	javac	2m 15s		the patch passed
+1 💚	javadoc	1m 6s		the patch passed
+1 💚	shadedjars	6m 30s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 31s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 1s		hbase-client in the patch passed.
+1 💚	unit	209m 46s		hbase-server in the patch passed.
+1 💚	unit	6m 54s		hbase-shell in the patch passed.
		258m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7578
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c4c5d8cd5fa2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a50259f`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/testReport/
Max. process+thread count	3353 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-12-31T11:27:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 29s		branch-2 passed
+1 💚	compile	1m 42s		branch-2 passed
+1 💚	javadoc	1m 2s		branch-2 passed
+1 💚	shadedjars	5m 30s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 30s		the patch passed
+1 💚	compile	1m 44s		the patch passed
+1 💚	javac	1m 44s		the patch passed
+1 💚	javadoc	1m 2s		the patch passed
+1 💚	shadedjars	5m 30s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 24s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	7m 57s		hbase-client in the patch passed.
+1 💚	unit	215m 27s		hbase-server in the patch passed.
+1 💚	unit	7m 11s		hbase-shell in the patch passed.
		259m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7578
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux b809c4758720 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a50259f`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/testReport/
Max. process+thread count	3282 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7578/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

sidkhillon mentioned this pull request Dec 26, 2025

HBASE-29796 Allow sleepForRetry replication config to be overridden by replication peers #7577

Open

sidkhillon commented Dec 26, 2025

View reviewed changes