Skip to content

feat: Add IEEE 754 float16 (binary16) support to Rust runtime #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AshharAhmadKhan wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Add IEEE 754 float16 (binary16) support to Rust runtime #3252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
190cea8
feat: Add IEEE 754 float16 (binary16) support to Rust runtime
AshharAhmadKhan Feb 2, 2026
fce43ec
fix: Suppress clippy warnings for float16 naming and unused constant
AshharAhmadKhan Feb 2, 2026
ffd14f9
fix: Add license header and suppress clippy trait warnings
AshharAhmadKhan Feb 3, 2026
b785961
fix: Complete CI fixes for clippy and imports
AshharAhmadKhan Feb 3, 2026
06a245a
fix: Add missing blank line after license header in number.rs
AshharAhmadKhan Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion rust/fory-core/src/buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
// under the License.

use crate::error::Error;
use crate::float16::float16;
use crate::meta::buffer_rw_string::read_latin1_simd;
use byteorder::{ByteOrder, LittleEndian};
use std::cmp::max;
Expand Down Expand Up @@ -390,6 +391,12 @@ impl<'a> Writer<'a> {
}
}

// ============ FLOAT16 (TypeId = 16) ============
#[inline(always)]
pub fn write_f16(&mut self, value: float16) {
self.write_u16(value.to_bits());
}

// ============ FLOAT64 (TypeId = 18) ============

#[inline(always)]
Expand Down Expand Up @@ -854,8 +861,13 @@ impl<'a> Reader<'a> {
}

// ============ FLOAT64 (TypeId = 18) ============

#[inline(always)]
pub fn read_f16(&mut self) -> Result<float16, Error> {
let bits = LittleEndian::read_u16(self.slice_after_cursor());
self.cursor += 2;
Ok(float16::from_bits(bits))
}

pub fn read_f64(&mut self) -> Result<f64, Error> {
let slice = self.slice_after_cursor();
let result = LittleEndian::read_f64(slice);
Expand Down
Loading
Loading