fix(java): Compatible mode on de/serialize api failed to deserialize#1996
Merged
chaokunyang merged 11 commits intoapache:mainfrom Jan 7, 2025
Merged
fix(java): Compatible mode on de/serialize api failed to deserialize#1996chaokunyang merged 11 commits intoapache:mainfrom
chaokunyang merged 11 commits intoapache:mainfrom
Conversation
orisgarno
changed the title
orisgarno
force-pushed
the
fix-compatible-mode
branch
from
d9dd748 to
1c7a45f
Compare
orisgarno
requested review from
PragmaTwice,
chaokunyang and
theweipeng
as code owners
chaokunyang
reviewed
Jan 6, 2025
java/fury-format/src/test/java/org/apache/fury/format/type/DataTypeTest.java
Outdated
Show resolved
Hide resolved
chaokunyang
reviewed
Jan 6, 2025
chaokunyang
reviewed
Jan 6, 2025
Collaborator
chaokunyang
left a comment
chaokunyang
left a comment
There was a problem hiding this comment.
LGTM overall, just a few minor comments
chaokunyang
reviewed
Jan 7, 2025
chaokunyang
reviewed
Jan 7, 2025
Co-authored-by: Shawn Yang <[email protected]>
Co-authored-by: Shawn Yang <[email protected]>
Contributor
Author
|
@chaokunyang Thanks for merging this PR. |
Collaborator
|
AS the #1972 (comment) said, current way to deserialize the data into another type nees class registration, this is not flexible, we'd better support automatic deserializing into another type before making a release. Would you like to help? @orisgarno |
Contributor
Author
|
Will try to look into that first, i'll reach you out if i have anything to clarify. @chaokunyang |
Collaborator
chaokunyang
added a commit
that referenced
this pull request
Feb 7, 2025
…1996) ## What does this PR do? Read and write class data on COMPATIBLE mode for de/serializeJavaObject api. When COMPATIBLE mode is on and need to serialize and deserialize different POJO, users are required to register classes those are going to be serialized or deserialized. ## Related issues <!-- Is there any related issue? Please attach here. - #xxxx0 - #xxxx1 - #xxxx2 --> ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fury/issues/new/choose) describing the need to do so and update the document if necessary. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. --> --------- Co-authored-by: Shawn Yang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Read and write class data on COMPATIBLE mode for de/serializeJavaObject api.
When COMPATIBLE mode is on and need to serialize and deserialize different POJO, users are required to register classes those are going to be serialized or deserialized.
Related issues
Does this PR introduce any user-facing change?
Benchmark