Skip to content

[fix](iceberg) Execute empty static overwrite and stabilize info_schema timezone test#65105

Open
suxiaogang223 wants to merge 3 commits into
apache:masterfrom
suxiaogang223:codex/pick-62344-master
Open

[fix](iceberg) Execute empty static overwrite and stabilize info_schema timezone test#65105
suxiaogang223 wants to merge 3 commits into
apache:masterfrom
suxiaogang223:codex/pick-62344-master

Conversation

@suxiaogang223

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: None

Related PR: #62344

Problem Summary: Pick #62344 from branch-4.1 to master. The source PR fixes Iceberg static partition overwrite when the source query is optimized to an empty relation, and stabilizes the information_schema.rowsets timezone regression case. git cherry showed the three source commits were not present on origin/master, so this PR applies them to master. The only pick conflict was in test_information_schema_timezone.groovy; the resolution keeps the current master offset timezone coverage and applies the stable rowsets query helper from the source PR.

Release note

Fix Iceberg static partition overwrite when the source query is empty.

Check List (For Author)

  • Test: Manual test
    • git diff --check origin/master..HEAD
  • Behavior changed: Yes. Empty-source Iceberg static partition overwrite can execute the overwrite path instead of being skipped as empty.
  • Does this need documentation: No

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223 suxiaogang223 marked this pull request as ready for review July 1, 2026 09:26
@suxiaogang223

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29686 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 11de1137b2ecb26589343779a51f6701da562376, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17718	3982	3983	3982
q2	2025	319	205	205
q3	10287	1414	829	829
q4	4683	478	350	350
q5	7607	882	598	598
q6	183	170	137	137
q7	775	842	638	638
q8	9323	1550	1460	1460
q9	5650	4429	4437	4429
q10	6773	1812	1554	1554
q11	512	349	325	325
q12	726	565	435	435
q13	18109	3403	2719	2719
q14	261	259	242	242
q15	q16	789	780	709	709
q17	1036	1034	1005	1005
q18	6934	5760	5567	5567
q19	1362	1363	1105	1105
q20	742	626	552	552
q21	5937	2713	2546	2546
q22	441	367	299	299
Total cold run time: 101873 ms
Total hot run time: 29686 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4340	4226	4306	4226
q2	293	314	218	218
q3	4538	4923	4403	4403
q4	2082	2182	1361	1361
q5	4390	4300	4287	4287
q6	234	176	131	131
q7	1696	1928	1822	1822
q8	2488	2168	2175	2168
q9	8129	8203	7768	7768
q10	4831	4737	4355	4355
q11	563	416	365	365
q12	745	777	546	546
q13	3311	3513	2972	2972
q14	304	286	266	266
q15	q16	711	729	646	646
q17	1337	1321	1314	1314
q18	7774	7327	7176	7176
q19	1142	1125	1155	1125
q20	2210	2192	1951	1951
q21	5223	4522	4422	4422
q22	524	462	414	414
Total cold run time: 56865 ms
Total hot run time: 51936 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 174611 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 11de1137b2ecb26589343779a51f6701da562376, data reload: false

query5	4305	644	484	484
query6	476	214	196	196
query7	4885	593	354	354
query8	335	195	177	177
query9	8758	4011	4013	4011
query10	460	367	299	299
query11	5905	2394	2114	2114
query12	163	102	101	101
query13	1341	566	437	437
query14	6256	5286	4935	4935
query14_1	4312	4237	4298	4237
query15	212	202	180	180
query16	998	470	446	446
query17	924	711	563	563
query18	2419	461	345	345
query19	206	187	145	145
query20	109	107	105	105
query21	236	161	133	133
query22	13687	13629	13354	13354
query23	17417	16553	16189	16189
query23_1	16295	16285	16289	16285
query24	7726	1786	1279	1279
query24_1	1323	1334	1322	1322
query25	571	485	393	393
query26	1327	349	208	208
query27	2621	604	398	398
query28	4484	2039	2071	2039
query29	1086	628	491	491
query30	338	267	225	225
query31	1119	1104	987	987
query32	107	65	64	64
query33	519	324	263	263
query34	1172	1130	667	667
query35	777	789	684	684
query36	1450	1412	1216	1216
query37	152	115	93	93
query38	1893	1704	1660	1660
query39	928	924	893	893
query39_1	880	881	875	875
query40	260	169	147	147
query41	71	70	70	70
query42	95	96	95	95
query43	324	329	286	286
query44	1434	793	784	784
query45	210	194	186	186
query46	1117	1206	765	765
query47	2428	2377	2267	2267
query48	422	443	287	287
query49	592	429	346	346
query50	1170	429	344	344
query51	4423	4435	4415	4415
query52	88	89	78	78
query53	266	281	203	203
query54	288	239	226	226
query55	78	73	70	70
query56	316	303	307	303
query57	1452	1411	1358	1358
query58	308	259	256	256
query59	1556	1605	1424	1424
query60	315	283	268	268
query61	208	153	141	141
query62	689	648	587	587
query63	248	201	214	201
query64	2530	776	598	598
query65	4858	4732	4754	4732
query66	1824	509	392	392
query67	29636	29592	29557	29557
query68	3030	1480	1035	1035
query69	415	313	271	271
query70	1118	959	969	959
query71	349	335	315	315
query72	2892	2575	2327	2327
query73	831	783	435	435
query74	5134	4953	4761	4761
query75	2598	2591	2219	2219
query76	2364	1196	750	750
query77	352	373	286	286
query78	12538	12536	11797	11797
query79	1385	1174	781	781
query80	1291	543	448	448
query81	525	330	271	271
query82	631	158	123	123
query83	370	322	290	290
query84	323	158	127	127
query85	968	611	505	505
query86	419	305	275	275
query87	1834	1829	1772	1772
query88	3723	2804	2780	2780
query89	452	421	355	355
query90	1929	200	192	192
query91	209	186	156	156
query92	64	61	54	54
query93	1747	1549	984	984
query94	723	357	327	327
query95	808	513	465	465
query96	1141	798	372	372
query97	2702	2724	2575	2575
query98	212	210	199	199
query99	1177	1154	1024	1024
Total cold run time: 259807 ms
Total hot run time: 174611 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 11de1137b2ecb26589343779a51f6701da562376, data reload: false

query1	0.00	0.01	0.00
query2	0.10	0.06	0.05
query3	0.26	0.15	0.14
query4	1.61	0.13	0.15
query5	0.23	0.25	0.22
query6	1.22	1.06	1.08
query7	0.04	0.01	0.01
query8	0.06	0.04	0.04
query9	0.37	0.32	0.31
query10	0.58	0.55	0.53
query11	0.19	0.15	0.14
query12	0.17	0.14	0.15
query13	0.47	0.47	0.47
query14	1.00	1.00	1.01
query15	0.61	0.59	0.60
query16	0.32	0.32	0.33
query17	1.11	1.09	1.10
query18	0.24	0.21	0.22
query19	2.01	1.88	1.99
query20	0.02	0.01	0.01
query21	15.41	0.26	0.13
query22	4.78	0.05	0.05
query23	16.14	0.31	0.13
query24	2.96	0.45	0.31
query25	0.11	0.04	0.04
query26	0.72	0.22	0.14
query27	0.04	0.04	0.04
query28	3.53	0.92	0.52
query29	12.49	4.27	3.43
query30	0.28	0.15	0.18
query31	2.78	0.60	0.32
query32	3.22	0.61	0.49
query33	3.16	3.18	3.18
query34	15.62	4.20	3.56
query35	3.55	3.54	3.56
query36	0.55	0.44	0.43
query37	0.09	0.07	0.06
query38	0.06	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.17	0.16
query41	0.08	0.04	0.03
query42	0.03	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 96.47 s
Total hot run time: 25.17 s

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 2.15% (2/93) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants