-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[chore](cte) use a better way to get child in enforce regulator #59395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
morrySnow
wants to merge
1
commit into
apache:master
Choose a base branch
from
morrySnow:simple_get_children
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 36514 ms |
TPC-DS: Total hot run time: 179688 ms |
ClickBench: Total hot run time: 27.14 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
related PR #58964
Problem Summary:
This pull request refactors how child physical plans are accessed in the
ChildrenPropertiesRegulatorclass, simplifying the code and improving test clarity. The main change is the removal of thegetChildPhysicalPlanhelper method, replacing its usage with direct access to the plan from thechildrenlist. The tests are also updated to build child mocks more locally, improving test isolation and readability.Refactoring and Simplification
getChildPhysicalPlanmethod fromChildrenPropertiesRegulator, and replaced its usage invisitPhysicalFilterandvisitPhysicalProjectwith direct access to the child plan viachildren.get(0).getPlan(). This simplifies the code by eliminating unnecessary indirection. [1] [2] [3]Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)