Skip to content

[fix](storage-engine) _clean_unused_rowset_metas should skip rowsets in _unused_rowsets map #59390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Dec 26, 2025
Merged

[fix](storage-engine) _clean_unused_rowset_metas should skip rowsets in _unused_rowsets map #59390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion be/src/olap/storage_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,8 @@ void StorageEngine::_clean_unused_rowset_metas() {
return true;
}
if (rowset_meta->rowset_state() == RowsetStatePB::VISIBLE &&
(!tablet->rowset_meta_is_useful(rowset_meta))) {
(!tablet->rowset_meta_is_useful(rowset_meta)) &&
!check_rowset_id_in_unused_rowsets(rowset_id)) {
LOG(INFO) << "rowset meta is not used any more, remove it. rowset_id="
<< rowset_meta->rowset_id();
invalid_rowset_metas.push_back(rowset_meta);
Expand Down
6 changes: 4 additions & 2 deletions be/src/olap/tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,8 +920,10 @@ void Tablet::delete_expired_stale_rowset() {
if (config::enable_mow_verbose_log) {
LOG_INFO("finish delete_expired_stale_rowset for tablet={}", tablet_id());
}
DBUG_EXECUTE_IF("Tablet.delete_expired_stale_rowset.start_delete_unused_rowset",
{ _engine.start_delete_unused_rowset(); });
DBUG_EXECUTE_IF("Tablet.delete_expired_stale_rowset.start_delete_unused_rowset", {
_engine.start_delete_unused_rowset();
[[maybe_unused]] auto st = _engine.start_trash_sweep(nullptr);
});
}

Status Tablet::check_version_integrity(const Version& version, bool quiet) {
Expand Down
Loading