perf: optimize to_json (2x faster)#4902
Merged
andygrove merged 1 commit intoJul 13, 2026
Merged
Conversation
andygrove
changed the title
escape_string / to_json
andygrove
changed the title
escape_string / to_jsonescape_string / to_json (56% faster)
andygrove
changed the title
escape_string / to_json (56% faster)escape_string / to_json (2x faster)
andygrove
changed the title
escape_string / to_json (2x faster)to_json (2x faster)
mbutrovich
approved these changes
Jul 13, 2026
mbutrovich
left a comment
mbutrovich
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me, thanks @andygrove!
andygrove
deleted the
auto-opt/escape_string-datafusion-comet-20260712-091032
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Optimize existing expression.
What changes are included in this PR?
escape_string now returns Cow (zero-alloc borrow when nothing needs escaping) and bulk-copies unescaped byte runs instead of allocating and pushing char-by-char per string value in to_json.
How are these changes tested?
Existing tests
Benchmark (criterion):