Delete user-project mappings on project deletion

[Tonitzpp]

Description

When a user is added to a project, and this project is then deleted, the user-project mapping is never removed from the database. Thus, when attempting to delete the user's account, an error is returned stating that the account is still linked to a project.

Therefore, this PR deletes the invalid user-project mappings and fixes the project deletion process in CloudStack.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

1. A new project belonging to a domain admin account was created and a user was added to it.
2. In the database, I observed that select * from project_account had the entries for 1 account and 1 user belonging to the project.
3. I deleted the project.
4. I the database, using the same command, I observed that the mappings were removed after project deletion.
5. I deleted the user's account without receiving any errors.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (b26b70c) to head (847913e).
⚠️ Report is 5 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...ava/com/cloud/upgrade/dao/Upgrade42030to42040.java	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #13456   +/-   ##
=========================================
  Coverage     16.25%   16.26%           
- Complexity    13432    13437    +5     
=========================================
  Files          5667     5667           
  Lines        500670   500679    +9     
  Branches      60801    60800    -1     
=========================================
+ Hits          81401    81419   +18     
+ Misses       410163   410154    -9     
  Partials       9106     9106           

Flag	Coverage Δ
uitests	4.14% <ø> (ø)
unittests	17.11% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[winterhazel]

@blueorangutan package

[blueorangutan]

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18316

[DaanHoogland]

looks good, but will need extensive upgrade testing (will 20.2 -> 23.0 work?)

[weizhouapache]

@Tonitzpp
I am able to reproduce the issue #12601

I do not think this PR fixes it, as listAdministratedProjectIds is used to get the project accounts, which uses AdminSearch , not ProjectAccountSearch

cc @harikrishna-patnala @DaanHoogland

[weizhouapache]

@Tonitzpp
could you please address the comment if you have time ?
it would be great if you can verify the changes too

[Tonitzpp]

@weizhouapache I tested it again, with and without the changes, to see if was still possible to reproduce the issue #12601. I was able to reproduce it without, but not with my changes.

Here are the steps I executed:

1. Created a User account:
   

2. Created a project:
   

3. Added the User in the project as a user with the role type as admin:
   

4. Then, I deleted the project with clean up:
   

Before the changes, I tried to delete the account and the error showed up:

I checked the database too:

MariaDB [cloud]> select * from project_account;
+----+------------+---------+--------------+------------+--------------------+-----------------+---------------------+
| id | account_id | user_id | account_role | project_id | project_account_id | project_role_id | created             |
+----+------------+---------+--------------+------------+--------------------+-----------------+---------------------+
|  2 |          4 |       4 | Admin        |          1 |                  5 |            NULL | 2026-04-23 12:22:59 |
+----+------------+---------+--------------+------------+--------------------+-----------------+---------------------+
1 row in set (0.000 sec)

After the changes, I deleted the account successfully:

And checked the database that it was clean:
sql MariaDB [cloud]> select * from project_account; Empty set (0.000 sec)

Did you perform any different steps?

---

@DaanHoogland And in regards to the normalization, it will need to be included in the 4.22.1 -> 4.23.0 and 4.22.1 -> 4.22.2 scripts.

[DaanHoogland]

it will need to be included in the 4.22.1 -> 4.23.0 and 4.22.1 -> 4.22.2 scripts.

If it is idem potent we can just add it to both. that would be best. But if 22.2 is released after 23.0 it can not go in that upgrade, but must go into 22.2 -> 23.1!