Addition of the status filter in the backup listing API #13254
Conversation
GeanJS
force-pushed
the
add-filter-by-status
branch
from
9fa3f09 to
b058f0a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13254 +/- ##
============================================
+ Coverage 18.93% 20.14% +1.20%
- Complexity 18471 18472 +1
============================================
Files 6221 5751 -470
Lines 560045 519387 -40658
Branches 68289 60627 -7662
============================================
- Hits 106048 104614 -1434
+ Misses 442372 403344 -39028
+ Partials 11625 11429 -196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
GeanJS
changed the title
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm (uma pergunta)
bernardodemarco
left a comment
bernardodemarco
left a comment
There was a problem hiding this comment.
@GeanJS, code lgtm. I've just left one comment/suggestion here
Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>
erikbocks
left a comment
erikbocks
left a comment
There was a problem hiding this comment.
CLGTM. Didn't test it.
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@GeanJS |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18439 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
7 participants
Description
Currently, the
listBackupsAPI does not allow listing backups based on their status. Changes have been made to the API to allow backups to be listed informing a specific status. In addition, the backups filter of the graphical interface has been extended to support the search based on status.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
The PR was tested by verifying both via CloudMonkey and the graphical interface the possibility of filtering backups by status.
How did you try to break this feature and the system with this change?
I tried to break this feature by passing an invalid status in both the CloudMonkey and the browser URL. In the API response a message was returned informing that the passed value is an invalid status.