Skip to content

Conversation

@zhoujinsong
Copy link
Contributor

Why are the changes needed?

As titled.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.99%. Comparing base (cbdc517) to head (222fe01).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4023      +/-   ##
============================================
+ Coverage     22.12%   29.99%   +7.86%     
- Complexity     2461     4076    +1615     
============================================
  Files           445      646     +201     
  Lines         40897    51836   +10939     
  Branches       5767     6589     +822     
============================================
+ Hits           9050    15546    +6496     
- Misses        31089    35159    +4070     
- Partials        758     1131     +373     
Flag Coverage Δ
core 29.99% <ø> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants