Skip to content

Conversation

@davedwwang
Copy link
Contributor

@davedwwang davedwwang commented Dec 11, 2025

Why are the changes needed?

The current Dashboard login uses an admin-user with a plaintext password, which is highly insecure. To enhance security, centralize user management, and align with industry standard practices, we need to switch to LDAP authentication.

Close #4008.

Brief change log

  • Introduced three new login-related configurations in AmoroManagementConf.
  • Added LdapPasswdAuthenticationProvider to support LDAP integration (implements PasswdAuthenticationProvider).
  • Updated LoginController to use PasswdAuthenticationProvider for user login validation.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no) yes
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not documented

@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Dec 11, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.78%. Comparing base (cbdc517) to head (3c9c606).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #4009       +/-   ##
============================================
- Coverage     22.12%   4.78%   -17.35%     
+ Complexity     2461     471     -1990     
============================================
  Files           445     446        +1     
  Lines         40897   40951       +54     
  Branches       5767    5767               
============================================
- Hits           9050    1958     -7092     
- Misses        31089   38799     +7710     
+ Partials        758     194      -564     
Flag Coverage Δ
trino 4.78% <ø> (-17.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davedwwang davedwwang force-pushed the dev/ldap_auth branch 2 times, most recently from cea2c1a to e986923 Compare December 12, 2025 17:00
@davedwwang
Copy link
Contributor Author

hi @turboFei Would you mind reviewing this? I’d really appreciate it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module type:build type:docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Support LDAP Authentication for Dashboard Login

2 participants