Skip to content

Conversation

@wardlican
Copy link
Contributor

Why are the changes needed?

In master-slave mode, each optimizer needs to communicate with each ams node. Therefore, the registration mode of the optimizer needs to be modified in master-slave mode. The optimizer only reports heartbeats to the master node. Only the master node will maintain whether the optimizer's heartbeat has timed out. The slave node loads optimizer information from the database to detect whether there are any new or deleted optimizers.

Close #3929 .

Brief change log

  • In master-slave mode, only the master node is responsible for maintaining the addition and expiration of optimizers.
  • Slave nodes periodically detect the addition and deletion of optimizers from the database.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

wardli added 17 commits October 29, 2025 17:49
@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 15, 2025
@wardlican
Copy link
Contributor Author

Please perform CR on these implementations.

@github-actions github-actions bot removed the stale label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask]: In master-slave mode, each AMS should automatically senses the optimizer.

1 participant