Skip to content

Conversation

@xuzifu666
Copy link
Member

Why are the changes needed?

Close #3914.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@xuzifu666 xuzifu666 changed the title [Improvement]: Support get statistics from Paimon [AMORO-3914] Support get statistics from Paimon Nov 7, 2025
@czy006
Copy link
Contributor

czy006 commented Dec 11, 2025

@xuzifu666 Will this api be compatible with the viewing of iceberg static information in the future?

Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions

@Override
public StatisticsBaseInfo getTableStatistics(AmoroTable<?> amoroTable) {
// hudi doesn't support statistics
return new StatisticsBaseInfo();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default implementation we can make in the interface is:throw new UnsupportedOperationException

statistics.schemaId(),
statistics.mergedRecordCount().getAsLong(),
statistics.mergedRecordSize().getAsLong(),
Collections.emptyMap());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's about colStats info ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Support get statistics from Paimon

3 participants