-
Notifications
You must be signed in to change notification settings - Fork 368
[AMORO-3914] Support get statistics from Paimon #3915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@xuzifu666 Will this api be compatible with the viewing of iceberg static information in the future? |
czy006
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some suggestions
| @Override | ||
| public StatisticsBaseInfo getTableStatistics(AmoroTable<?> amoroTable) { | ||
| // hudi doesn't support statistics | ||
| return new StatisticsBaseInfo(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default implementation we can make in the interface is:throw new UnsupportedOperationException
| statistics.schemaId(), | ||
| statistics.mergedRecordCount().getAsLong(), | ||
| statistics.mergedRecordSize().getAsLong(), | ||
| Collections.emptyMap()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's about colStats info ?
Why are the changes needed?
Close #3914.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation