Watch transitive proto imports in build#275
Merged
iainmcgin merged 2 commits intoJul 8, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Also cite the PR in the changelog fragment and align its timestamp with the filename. No-Verification-Needed: doc/changelog-only fixups
iainmcgin
approved these changes
Jul 8, 2026
iainmcgin
left a comment
Collaborator
There was a problem hiding this comment.
[claude code] Thanks @fallintoplace — clean, correct, and well-tested. Verified end-to-end: the descriptor set carries the transitive closure (--include_imports is unconditional), the resolver's include-root iteration deliberately mirrors protoc's -I order, explicitly-listed files stay watched unconditionally, and the traversal guard is sound. Pushed a small fixup (d59ec3a): doc notes for the deliberate WKT non-watch and the resolver's guards, plus changelog fragment polish. Will queue for merge once CI runs.
Collaborator
|
[claude code] Merged as 88e854f — thanks @fallintoplace! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation