Skip to content

Watch transitive proto imports in build#275

Merged
iainmcgin merged 2 commits into
anthropics:mainfrom
fallintoplace:fix/buffa-build-transitive-rerun
Jul 8, 2026
Merged

Watch transitive proto imports in build#275
iainmcgin merged 2 commits into
anthropics:mainfrom
fallintoplace:fix/buffa-build-transitive-rerun

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • Make Protoc mode emit Cargo rerun watches from the decoded descriptor set, so resolved transitive imports trigger codegen again.
  • Keep explicitly listed input files watched, and skip descriptor names that do not resolve safely under configured include roots.
  • Add unit coverage and a changelog fragment for the build rerun behavior.

Validation

  • cargo test --workspace --all-features
  • cargo clippy --workspace --all-targets --all-features -- -D warnings

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Also cite the PR in the changelog fragment and align its timestamp with
the filename.

No-Verification-Needed: doc/changelog-only fixups

@iainmcgin iainmcgin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[claude code] Thanks @fallintoplace — clean, correct, and well-tested. Verified end-to-end: the descriptor set carries the transitive closure (--include_imports is unconditional), the resolver's include-root iteration deliberately mirrors protoc's -I order, explicitly-listed files stay watched unconditionally, and the traversal guard is sound. Pushed a small fixup (d59ec3a): doc notes for the deliberate WKT non-watch and the resolver's guards, plus changelog fragment polish. Will queue for merge once CI runs.

@iainmcgin iainmcgin added this pull request to the merge queue Jul 8, 2026
Merged via the queue into anthropics:main with commit 88e854f Jul 8, 2026
9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2026
@iainmcgin

Copy link
Copy Markdown
Collaborator

[claude code] Merged as 88e854f — thanks @fallintoplace!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants