🛡️ Sentinel: [HIGH] Fix Inconsistent LaTeX RCE & DoS Mitigation

[anchapin]

🚨 Severity: HIGH
💡 Vulnerability: CoverLetterGenerator and PDFConverter execute pdflatex and pandoc using subprocess.Popen but fail to enforce -no-shell-escape and processing timeouts. These mitigations were present in TemplateGenerator but inconsistently missed here.
🎯 Impact: This allows malicious user input (e.g., \write18) or AI hallucinations injected into the LaTeX source to result in Remote Code Execution (RCE) on the host machine. Furthermore, intentionally complex or recursive LaTeX payloads could cause the underlying subprocess to hang indefinitely, resulting in a Denial of Service (DoS) by exhausting server resources.
🔧 Fix: Added -no-shell-escape (for pdflatex) and --pdf-engine-opt=-no-shell-escape (for pandoc) to the arguments. Applied a strict 30-second timeout to the communicate() calls and implemented robust explicit cleanup (catching TimeoutExpired, executing kill(), and calling communicate() again). Symmetrically applied these fixes to both missing modules.
✅ Verification: Ran the full test suite (pytest) successfully. Added new robust unittests to tests/test_pdf_security.py using subprocess.Popen mocks and environment patches to explicitly verify process timeouts are handled and security flags are passed into CoverLetterGenerator and PDFConverter. Verified via local black and flake8 execution.

---

PR created automatically by Jules for task 5980168402611118692 started by @anchapin

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Sorry @anchapin, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery