AD8366 Driver upstream update #3026

rodrigo455 · 2025-11-21T16:54:44Z

PR Description

This series modernizes the AD8366 amplifier/attenuator driver and adds support for additional device variants.

Adds support for HMC271 (legacy/obsolete part maintained in ADI tree)
Adds support for multiple digital step attenuators:
ADRF5720: 0.5 dB LSB, 6-Bit, Digital Attenuator, 9 kHz to 40 GHz
ADRF5730: 0.5 dB LSB, 6-Bit, Digital Attenuator, 100 MHz to 40 GHz
ADRF5731: 2 dB LSB, 4-Bit, Digital Attenuator, 100 MHz to 40 GHz
HMC1018A: 1.0 dB LSB GaAs MMIC 5-BIT DIGITAL ATTENUATOR, 0.1 - 30 GHz
HMC1019A: 0.5 dB LSB GaAs MMIC 5-BIT DIGITAL ATTENUATOR, 0.1 - 30 GHz

Device Tree Support:

Adds device tree binding documentation
Adds device tree compatible strings for all supported devices

PR Type

Bug fix (a change that fixes an issue)
New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

I have conducted a self-review of my own code changes
I have compiled my changes, including the documentation
I have tested the changes on the relevant hardware
I have updated the documentation outside this repo accordingly
I have provided links for the relevant upstream lore

nunojsa

You should still add your sob tag for Michael's patches. If you actually change them in any meaningful way you should add co-authored-by tag. See git log for examples

drivers/iio/amplifiers/ad8366.c

Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml

MAINTAINERS

drivers/iio/amplifiers/ad8366.c

nunojsa

Second round

Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml

MAINTAINERS

drivers/iio/amplifiers/ad8366.c

This patch series modernizes the AD8366 amplifier/attenuator driver with several improvements and adds support for additional device variants. Device Support Expansion: - Adds support for HMC271 (legacy/obsolete part maintained in ADI tree) - Adds support for multiple digital step attenuators: - ADRF5720: 0.5 dB LSB, 6-Bit, Digital Attenuator, 9 kHz to 40 GHz - ADRF5730: 0.5 dB LSB, 6-Bit, Digital Attenuator, 100 MHz to 40 GHz - ADRF5731: 2 dB LSB, 4-Bit, Digital Attenuator, 100 MHz to 40 GHz - HMC1018A: 1.0 dB LSB GaAs MMIC 5-BIT DIGITAL ATTENUATOR, 0.1 - 30 GHz - HMC1019A: 0.5 dB LSB GaAs MMIC 5-BIT DIGITAL ATTENUATOR, 0.1 - 30 GHz Device Tree Support: - Adds device tree binding documentation - Adds device tree compatible strings for all supported devices # Describe the purpose of this series. The information you put here # will be used by the project maintainer to make a decision whether # your patches should be reviewed, and in what priority order. Please be # very detailed and link to any relevant discussions or sites that the # maintainer can review to better understand your proposed changes. If you # only have a single patch in your series, the contents of the cover # letter will be appended to the "under-the-cut" portion of the patch. # Lines starting with # will be removed from the cover letter. You can # use them to add notes or reminders to yourself. If you want to use # markdown headers in your cover letter, start the line with ">#". # You can add trailers to the cover letter. Any email addresses found in # these trailers will be added to the addresses specified/generated # during the b4 send stage. You can also run "b4 prep --auto-to-cc" to # auto-populate the To: and Cc: trailers based on the code being # modified. Signed-off-by: Rodrigo Alencar <[email protected]> --- b4-submit-tracking --- # This section is used internally by b4 prep for tracking purposes. { "series": { "revision": 1, "change-id": "20251121-iio-ad8366-update-56abac58bbca", "prefixes": [] } }

Add maintainers fragment for drivers/iio/amplifiers/ad8366.c Signed-off-by: Rodrigo Alencar <[email protected]>

Add device tree binding documentation for amplifiers and digital attenuators. This covers different device variants with similar SPI control. Signed-off-by: Rodrigo Alencar <[email protected]>

Some parts may consume enable GPIO to set serial mode (PS pin) or powerup the device (e.g. ADA4961's PWUP pin). Co-developed-by: Michael Hennerich <[email protected]> Signed-off-by: Michael Hennerich <[email protected]> Signed-off-by: Rodrigo Alencar <[email protected]>

This patch adds support for following digital step attenuators: * HMC271A: 1dB LSB 5-Bit Digital Attenuator SMT, 0.7 - 3.7 GHz * ADRF5720: 0.5 dB LSB, 6-Bit, Digital Attenuator, 9 kHz to 40 GHz * ADRF5730: 0.5 dB LSB, 6-Bit, Digital Attenuator, 100 MHz to 40 GHz * ADRF5731: 2 dB LSB, 4-Bit, Digital Attenuator, 100 MHz to 40 GHz * HMC1018A: 1.0 dB LSB GaAs MMIC 5-BIT DIGITAL ATTENUATOR, 0.1 - 30 GHz * HMC1019A: 0.5 dB LSB GaAs MMIC 5-BIT DIGITAL ATTENUATOR, 0.1 - 30 GHz Co-developed-by: Alexandru Ardelean <[email protected]> Signed-off-by: Alexandru Ardelean <[email protected]> Co-developed-by: Michael Hennerich <[email protected]> Signed-off-by: Michael Hennerich <[email protected]> Signed-off-by: Rodrigo Alencar <[email protected]>

Changes related to mutex handling: - use guard() from cleanup for mutex locking - replace mutex_init() for devm_mutex_init() Signed-off-by: Rodrigo Alencar <[email protected]>

Device resource managed simplified with: - voltage regulator managed internally by the device. - IIO device registration handled with devm_iio_device_register(). - removal of goto's from the probe function. - ad8366_remove() removed as it is not needed anymore. Also, dev_err_probe() is used to report probe errors with created local device pointer. Signed-off-by: Rodrigo Alencar <[email protected]>

Device-tree support achieved dropping the enum ID in favor of an extended chip info table: - gain step and number of channels moved to chip info - pack_code function added to describe how SPI buffer is populated With this, switch cases on the device type were dropped: - simplified read_raw and write_raw callbacks - number of channels retrieved from chip info in probe function Signed-off-by: Rodrigo Alencar <[email protected]>

nunojsa

Just some minor stuff. Feel free to send the patches

nunojsa · 2026-01-18T10:15:14Z

MAINTAINERS

 F:	Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
 F:	drivers/iio/adc/ad7780.c

+ANALOG DEVICES INC AD8366 DRIVER


Not really related to the change but on the commit message replace: s/fragment/entry

nunojsa · 2026-01-18T10:17:06Z

drivers/iio/amplifiers/ad8366.c

 *   HMC1119 0.25 dB LSB, 7-Bit, Silicon Digital Attenuator
 *
- * Copyright 2012-2019 Analog Devices Inc.
+ * Copyright 2012-2026 Analog Devices Inc.


Could mention this change in the commit message

nunojsa · 2026-01-18T10:21:05Z

drivers/iio/amplifiers/ad8366.c

 		.gain_max = 20500,
+		.gain_step = 253,
+		.num_channels = 2,
+		.pack_code = ad8366_pack_code,


Note that given that you're doing the above, you might be asked to ditch the array in favor of dedicated variables (that is the preferred way in IIO).

rodrigo455 requested review from CiprianRegus, amiclaus, btogorean, buha, chegbeli, danmois, dbogdan, machschmitt, mhennerich, nunojsa and rbolboac as code owners November 21, 2025 16:54

rodrigo455 marked this pull request as draft November 21, 2025 16:56

rodrigo455 force-pushed the staging/jic23_iio_ad8366-update branch from 378f2b8 to df90254 Compare November 21, 2025 17:08

github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 3 times, most recently from 573459b to 3982c2b Compare November 23, 2025 23:59

nunojsa reviewed Nov 24, 2025

View reviewed changes

rodrigo455 force-pushed the staging/jic23_iio_ad8366-update branch from df90254 to 02e319f Compare November 24, 2025 18:09

github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 7 times, most recently from 7770c62 to 7dea437 Compare November 30, 2025 23:59

github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 5 times, most recently from c477eb9 to 289f20e Compare December 5, 2025 23:59

github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 3 times, most recently from 416107d to 4882618 Compare January 5, 2026 00:02

nunojsa reviewed Jan 5, 2026

View reviewed changes

github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch from 4882618 to d6de80f Compare January 6, 2026 00:00

rodrigo455 added 8 commits January 6, 2026 10:33

MAINTAINERS: Add missing maintainer fragment for AD8366 driver

e40190b

Add maintainers fragment for drivers/iio/amplifiers/ad8366.c Signed-off-by: Rodrigo Alencar <[email protected]>

dt-bindings: iio: amplifiers: Add AD8366 support

3f3a49f

Add device tree binding documentation for amplifiers and digital attenuators. This covers different device variants with similar SPI control. Signed-off-by: Rodrigo Alencar <[email protected]>

iio: amplifiers: ad8366: use cleanup.h mutex guard

aa5d0ce

Changes related to mutex handling: - use guard() from cleanup for mutex locking - replace mutex_init() for devm_mutex_init() Signed-off-by: Rodrigo Alencar <[email protected]>

rodrigo455 force-pushed the staging/jic23_iio_ad8366-update branch from 1733322 to 439d0e8 Compare January 6, 2026 12:12

github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 7 times, most recently from 76e2b67 to 12aeb0c Compare January 13, 2026 00:12

github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 5 times, most recently from 739b23a to b7877f6 Compare January 18, 2026 00:02

nunojsa reviewed Jan 18, 2026

View reviewed changes

github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 3 times, most recently from b7f2c5c to 0fd10c6 Compare January 21, 2026 00:09

AD8366 Driver upstream update #3026

Are you sure you want to change the base?

AD8366 Driver upstream update #3026

Uh oh!

Conversation

rodrigo455 commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

PR Type

PR Checklist

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nunojsa left a comment

Choose a reason for hiding this comment

Uh oh!

nunojsa Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

nunojsa Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

nunojsa Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rodrigo455 commented Nov 21, 2025 •

edited

Loading