Support Voice Memos file drops for meeting transcription(#219)#507
Draft
Yaomeng1749 wants to merge 1 commit into
Draft
Support Voice Memos file drops for meeting transcription(#219)#507Yaomeng1749 wants to merge 1 commit into
Yaomeng1749 wants to merge 1 commit into
Conversation
Author
|
Rebased on current This fixes the import path that Voice Memos uses when dragging recordings into Meeting Transcription: those drops arrive as promised files, not just plain file URLs. The view now accepts both normal file URLs and file promises, supports multiple selected files, and queues the selected files for sequential transcription. Checks run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #219
Summary
Tests
swiftlint --strict --config .swiftlint.ymlxcodebuild test -quiet -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS' -derivedDataPath /Users/yaomeng/Library/Developer/Xcode/DerivedData/Fluid-afdlxoaqyckzxcdgcnblcegocvnz -clonedSourcePackagesDirPath /Users/yaomeng/Library/Developer/Xcode/DerivedData/Fluid-afdlxoaqyckzxcdgcnblcegocvnz/SourcePackages -disableAutomaticPackageResolution -only-testing:FluidDictationIntegrationTests/DictationE2ETests/testMeetingTranscriptionFileImport_filtersAndDedupesSupportedURLs -only-testing:FluidDictationIntegrationTests/DictationE2ETests/testMeetingTranscriptionFileImport_registersFileURLAndPromiseDropTypes -only-testing:FluidDictationIntegrationTests/DictationE2ETests/testMeetingTranscriptionFileImport_detectsAudioItemProviderRepresentations CODE_SIGNING_ALLOWED=NOLocal result bundle summary: 3 selected tests passed, 0 failed on macOS (My Mac). Xcode printed a CoreSimulator version warning before running the macOS tests.