Simplify upload check #421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return _files_match( | ||
| existing_file_url=other.file_info.url, | ||
| local_file_path=local_file_path, | ||
| ) |
There was a problem hiding this comment.
Bug: Type assertion only checks for UnoVideo, breaks other file blocks
The _file_blocks_match function asserts that other is specifically UnoVideo (line 140), but the function is designed to handle all four file block types (UnoImage, UnoVideo, UnoAudio, UnoPDF). This assertion will fail when comparing blocks of other file types, breaking equality checks for UnoImage, UnoAudio, and UnoPDF blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Replaces custom block equivalence with standard equality, adding custom equality for file blocks that compares metadata and file content to support local-file URLs.
src/_notion_scripts/upload.py):_find_last_matching_block_indexnow relies on standard==instead of a custom comparator._file_blocks_matchand_new_file_equality; monkey-patches__eq__forImage,Video,Audio, andPDFblocks to compare metadata and SHA-256 of localfile://sources against existing Notion files.Written by Cursor Bugbot for commit 45111ee. This will update automatically on new commits. Configure here.