Skip to content

Conversation

@ttypic
Copy link
Contributor

@ttypic ttypic commented Feb 2, 2026

Description

  • Use enums instead of string literals for message actions in java and python
  • Use messages constructor for python publishes

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch AIT-278/small-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ttypic ttypic requested a review from GregHolmes February 2, 2026 10:42
current = responses.get(message.serial, '')
responses[message.serial] = current + message.data
elif action == 'message.update':
elif action == MessageAction.MESSAGE_UPDATE':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif action == MessageAction.MESSAGE_UPDATE':
elif action == MessageAction.MESSAGE_UPDATE:

# New response started
responses[message.serial] = message.data
elif action == 'message.append':
elif action == MessageAction.MESSAGE_APPEND':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif action == MessageAction.MESSAGE_APPEND':
elif action == MessageAction.MESSAGE_APPEND:

… and python

use messages constructor for python publishes
@GregHolmes GregHolmes merged commit 01f243a into main Feb 2, 2026
7 checks passed
@GregHolmes GregHolmes deleted the AIT-278/small-fix branch February 2, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants