Skip to content

feat: STM32 Add option for UART to use DMA for sending byte #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattnite merged 1 commit into from
Dec 30, 2025
Merged

feat: STM32 Add option for UART to use DMA for sending byte #796

mattnite merged 1 commit into from
Dec 30, 2025

Conversation

@mathk
Copy link
Collaborator

@mathk mathk commented Dec 28, 2025

No description provided.

github-actions[bot]
github-actions bot previously requested changes Dec 28, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 3 issues on changed lines in 1 file:

  • port/stmicro/stm32/src/hals/common/bdma_v1.zig: 3 issues
ℹ️ Additional issues on unchanged lines 
The following 14 issue(s) exist but are not on lines changed in this PR:

build.zig:405: TODO style comments need to have a linked microzig issue on the same line.
build.zig:658: TODO style comments need to have a linked microzig issue on the same line.
build.zig:698: TODO style comments need to have a linked microzig issue on the same line.
build.zig:714: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:40: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:46: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:51: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:52: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:665: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/generate.zig:269: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:83: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:85: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:88: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.

@github-actions github-actions bot dismissed their stale review December 28, 2025 16:32

Updating with new lint results

github-actions[bot]
github-actions bot previously requested changes Dec 28, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 1 issue on changed lines in 1 file:

  • port/stmicro/stm32/src/hals/common/bdma_v1.zig: 1 issue
ℹ️ Additional issues on unchanged lines 
The following 23 issue(s) exist but are not on lines changed in this PR:

build.zig:405: TODO style comments need to have a linked microzig issue on the same line.
build.zig:658: TODO style comments need to have a linked microzig issue on the same line.
build.zig:698: TODO style comments need to have a linked microzig issue on the same line.
build.zig:714: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:40: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:46: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:51: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:52: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:665: TODO style comments need to have a linked microzig issue on the same line.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/generate.zig:269: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:1: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:120: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:122: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:285: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:439: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:561: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:577: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:83: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:85: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:88: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.

@mathk mathk marked this pull request as ready for review December 28, 2025 16:48
@mathk mathk marked this pull request as draft December 29, 2025 12:39
@github-actions github-actions bot dismissed their stale review December 29, 2025 17:41

Updating with new lint results

github-actions[bot]
github-actions bot previously requested changes Dec 29, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 7 issues on changed lines in 3 files:

  • port/stmicro/stm32/src/hals/common/bdma_v1.zig: 4 issues
  • port/stmicro/stm32/src/hals/common/enums.zig: 2 issues
  • port/stmicro/stm32/src/hals/common/uart_v3.zig: 1 issue
ℹ️ Additional issues on unchanged lines 
The following 46 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:121: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:325: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:850: Suggestion: Rename `IrqHandlerFn` to `IRQ_HandlerFn`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:879: Suggestion: Rename `HardFault_name` to `HardFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:880: Suggestion: Rename `BusFault_name` to `BusFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:881: Suggestion: Rename `MemManageFault_name` to `MemManageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:882: Suggestion: Rename `UsageFault_name` to `UsageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:11: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:18: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:19: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:25: Suggestion: Rename `AdcData` to `ADC_Data`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:19: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:27: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:28: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:29: Suggestion: Rename `ADC_pin3` to `ADC_Pin3`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:27: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:8: Suggestion: Rename `LcdRam` to `LCD_RAM`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:20: Suggestion: Rename `Lcd` to `LCD`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/generate.zig:272: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103.zig:24: Suggestion: Rename `Reset_Reason` to `ResetReason`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:309: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:30: Suggestion: Rename `RccPeriferals` to `RCC_Periferals`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:25: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:3: Suggestion: Rename `UART_V3_Type` to `UART_V3Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:5: Suggestion: Rename `I2C_V2_Type` to `I2C_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:7: Suggestion: Rename `SPI_V2_Type` to `SPI_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:82: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:87: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:228: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:429: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:436: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:471: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:87: Suggestion: Rename `Rcc` to `RCC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/embassy.zig:568: Suggestion: Rename `Item_t` to `ItemT`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:526: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:679: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:729: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:829: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1069: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1071: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1152: TODO style comments need to have a linked microzig issue on the same line.

@github-actions github-actions bot dismissed their stale review December 29, 2025 17:48

Updating with new lint results

github-actions[bot]
github-actions bot previously requested changes Dec 29, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 15 issues on changed lines in 5 files:

  • port/stmicro/stm32/src/hals/common/bdma_v1.zig: 4 issues
  • port/stmicro/stm32/src/hals/common/bdma_v2.zig: 4 issues
  • port/stmicro/stm32/src/hals/common/dma_common.zig: 4 issues
  • port/stmicro/stm32/src/hals/common/enums.zig: 2 issues
  • port/stmicro/stm32/src/hals/common/uart_v3.zig: 1 issue
ℹ️ Additional issues on unchanged lines 
The following 46 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:121: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:325: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:850: Suggestion: Rename `IrqHandlerFn` to `IRQ_HandlerFn`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:879: Suggestion: Rename `HardFault_name` to `HardFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:880: Suggestion: Rename `BusFault_name` to `BusFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:881: Suggestion: Rename `MemManageFault_name` to `MemManageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:882: Suggestion: Rename `UsageFault_name` to `UsageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:11: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:18: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:19: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:25: Suggestion: Rename `AdcData` to `ADC_Data`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:19: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:27: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:28: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:29: Suggestion: Rename `ADC_pin3` to `ADC_Pin3`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:27: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:8: Suggestion: Rename `LcdRam` to `LCD_RAM`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:20: Suggestion: Rename `Lcd` to `LCD`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/generate.zig:272: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103.zig:24: Suggestion: Rename `Reset_Reason` to `ResetReason`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:309: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:30: Suggestion: Rename `RccPeriferals` to `RCC_Periferals`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:25: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:3: Suggestion: Rename `UART_V3_Type` to `UART_V3Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:5: Suggestion: Rename `I2C_V2_Type` to `I2C_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:7: Suggestion: Rename `SPI_V2_Type` to `SPI_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:82: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:87: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:228: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:429: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:436: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:471: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:87: Suggestion: Rename `Rcc` to `RCC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/embassy.zig:568: Suggestion: Rename `Item_t` to `ItemT`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:526: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:679: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:729: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:829: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1069: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1071: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1152: TODO style comments need to have a linked microzig issue on the same line.

@mathk mathk marked this pull request as ready for review December 29, 2025 21:12
mattnite
mattnite requested changes Dec 29, 2025
View reviewed changes
@github-actions github-actions bot dismissed their stale review December 30, 2025 10:45

Updating with new lint results

github-actions[bot]
github-actions bot previously requested changes Dec 30, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 5 issues on changed lines in 4 files:

  • examples/nordic/nrf5x/build.zig: 1 issue
  • port/stmicro/stm32/src/hals/common/dma_common.zig: 1 issue
  • port/stmicro/stm32/src/hals/common/enums.zig: 2 issues
  • port/stmicro/stm32/src/hals/common/uart_v3.zig: 1 issue
ℹ️ Additional issues on unchanged lines 
The following 46 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:121: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:325: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:850: Suggestion: Rename `IrqHandlerFn` to `IRQ_HandlerFn`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:879: Suggestion: Rename `HardFault_name` to `HardFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:880: Suggestion: Rename `BusFault_name` to `BusFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:881: Suggestion: Rename `MemManageFault_name` to `MemManageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:882: Suggestion: Rename `UsageFault_name` to `UsageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:11: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:18: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:19: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:25: Suggestion: Rename `AdcData` to `ADC_Data`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:19: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:27: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:28: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:29: Suggestion: Rename `ADC_pin3` to `ADC_Pin3`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:27: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:8: Suggestion: Rename `LcdRam` to `LCD_RAM`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:20: Suggestion: Rename `Lcd` to `LCD`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/generate.zig:272: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103.zig:24: Suggestion: Rename `Reset_Reason` to `ResetReason`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:309: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:30: Suggestion: Rename `RccPeriferals` to `RCC_Periferals`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:25: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:3: Suggestion: Rename `UART_V3_Type` to `UART_V3Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:5: Suggestion: Rename `I2C_V2_Type` to `I2C_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:7: Suggestion: Rename `SPI_V2_Type` to `SPI_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:82: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:87: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:429: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:436: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:471: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:87: Suggestion: Rename `Rcc` to `RCC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/embassy.zig:568: Suggestion: Rename `Item_t` to `ItemT`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:526: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:679: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:729: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:829: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1069: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1071: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1152: TODO style comments need to have a linked microzig issue on the same line.

⚠️ Could not attach inline comments due to an error.

@mathk mathk force-pushed the dma_uart branch 2 times, most recently from ddb9bd7 to 9e6f2a8 Compare December 30, 2025 10:53
@github-actions github-actions bot dismissed their stale review December 30, 2025 10:53

Updating with new lint results

github-actions[bot]
github-actions bot previously requested changes Dec 30, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 4 issues on changed lines in 3 files:

  • port/stmicro/stm32/src/hals/common/dma_common.zig: 1 issue
  • port/stmicro/stm32/src/hals/common/enums.zig: 2 issues
  • port/stmicro/stm32/src/hals/common/uart_v3.zig: 1 issue
ℹ️ Additional issues on unchanged lines 
The following 46 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:121: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:325: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:850: Suggestion: Rename `IrqHandlerFn` to `IRQ_HandlerFn`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:879: Suggestion: Rename `HardFault_name` to `HardFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:880: Suggestion: Rename `BusFault_name` to `BusFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:881: Suggestion: Rename `MemManageFault_name` to `MemManageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:882: Suggestion: Rename `UsageFault_name` to `UsageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:11: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:18: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:19: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:25: Suggestion: Rename `AdcData` to `ADC_Data`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:19: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:27: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:28: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:29: Suggestion: Rename `ADC_pin3` to `ADC_Pin3`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:27: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:8: Suggestion: Rename `LcdRam` to `LCD_RAM`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:20: Suggestion: Rename `Lcd` to `LCD`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/generate.zig:272: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103.zig:24: Suggestion: Rename `Reset_Reason` to `ResetReason`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:309: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:30: Suggestion: Rename `RccPeriferals` to `RCC_Periferals`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:25: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:3: Suggestion: Rename `UART_V3_Type` to `UART_V3Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:5: Suggestion: Rename `I2C_V2_Type` to `I2C_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:7: Suggestion: Rename `SPI_V2_Type` to `SPI_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:82: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:87: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:429: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:436: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:471: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:87: Suggestion: Rename `Rcc` to `RCC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/embassy.zig:568: Suggestion: Rename `Item_t` to `ItemT`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:526: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:679: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:729: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:829: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1069: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1071: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1152: TODO style comments need to have a linked microzig issue on the same line.

@mathk mathk requested a review from mattnite December 30, 2025 12:16
mattnite
mattnite requested changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@mattnite mattnite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deal with the todo comment and we're good to go

@github-actions github-actions bot dismissed their stale review December 30, 2025 17:01

Updating with new lint results

github-actions[bot]
github-actions bot previously requested changes Dec 30, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 4 issues on changed lines in 3 files:

  • port/stmicro/stm32/src/hals/common/dma_common.zig: 1 issue
  • port/stmicro/stm32/src/hals/common/enums.zig: 2 issues
  • port/stmicro/stm32/src/hals/common/uart_v3.zig: 1 issue
ℹ️ Additional issues on unchanged lines 
The following 46 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:121: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:325: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:850: Suggestion: Rename `IrqHandlerFn` to `IRQ_HandlerFn`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:879: Suggestion: Rename `HardFault_name` to `HardFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:880: Suggestion: Rename `BusFault_name` to `BusFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:881: Suggestion: Rename `MemManageFault_name` to `MemManageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:882: Suggestion: Rename `UsageFault_name` to `UsageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:11: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:18: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:19: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:25: Suggestion: Rename `AdcData` to `ADC_Data`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:19: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:27: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:28: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:29: Suggestion: Rename `ADC_pin3` to `ADC_Pin3`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:27: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:8: Suggestion: Rename `LcdRam` to `LCD_RAM`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:20: Suggestion: Rename `Lcd` to `LCD`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/generate.zig:272: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103.zig:24: Suggestion: Rename `Reset_Reason` to `ResetReason`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:309: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:30: Suggestion: Rename `RccPeriferals` to `RCC_Periferals`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:25: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:3: Suggestion: Rename `UART_V3_Type` to `UART_V3Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:5: Suggestion: Rename `I2C_V2_Type` to `I2C_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:7: Suggestion: Rename `SPI_V2_Type` to `SPI_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:82: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:87: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:429: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:436: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:471: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:87: Suggestion: Rename `Rcc` to `RCC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/embassy.zig:568: Suggestion: Rename `Item_t` to `ItemT`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:526: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:679: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:729: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:829: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1069: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1071: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1152: TODO style comments need to have a linked microzig issue on the same line.

@github-actions github-actions bot dismissed their stale review December 30, 2025 17:04

Updating with new lint results

github-actions[bot]
github-actions bot previously requested changes Dec 30, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 3 issues on changed lines in 2 files:

  • port/stmicro/stm32/src/hals/common/enums.zig: 2 issues
  • port/stmicro/stm32/src/hals/common/uart_v3.zig: 1 issue
ℹ️ Additional issues on unchanged lines 
The following 46 issue(s) exist but are not on lines changed in this PR:

build-internals/build.zig:121: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:325: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:850: Suggestion: Rename `IrqHandlerFn` to `IRQ_HandlerFn`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:879: Suggestion: Rename `HardFault_name` to `HardFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:880: Suggestion: Rename `BusFault_name` to `BusFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:881: Suggestion: Rename `MemManageFault_name` to `MemManageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
core/src/cpus/cortex_m.zig:882: Suggestion: Rename `UsageFault_name` to `UsageFaultName`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:11: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:18: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:19: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/adc_dualmode.zig:25: Suggestion: Rename `AdcData` to `ADC_Data`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:19: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:27: Suggestion: Rename `ADC_pin1` to `ADC_Pin1`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:28: Suggestion: Rename `ADC_pin2` to `ADC_Pin2`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/stmicro/stm32/src/stm32f1xx/advanced_adc.zig:29: Suggestion: Rename `ADC_pin3` to `ADC_Pin3`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:27: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:8: Suggestion: Rename `LcdRam` to `LCD_RAM`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/boards/STM32L476DISCOVERY.zig:20: Suggestion: Rename `Lcd` to `LCD`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/generate.zig:272: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103.zig:24: Suggestion: Rename `Reset_Reason` to `ResetReason`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:309: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:30: Suggestion: Rename `RccPeriferals` to `RCC_Periferals`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:25: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:3: Suggestion: Rename `UART_V3_Type` to `UART_V3Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:5: Suggestion: Rename `I2C_V2_Type` to `I2C_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/enums.zig:7: Suggestion: Rename `SPI_V2_Type` to `SPI_V2Type`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:82: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:87: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:429: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:436: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:471: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/embassy.zig:87: Suggestion: Rename `Rcc` to `RCC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/embassy.zig:568: Suggestion: Rename `Item_t` to `ItemT`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:526: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:679: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:729: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:829: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1069: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1071: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1152: TODO style comments need to have a linked microzig issue on the same line.

@mathk mathk requested a review from mattnite December 30, 2025 17:06
mattnite
mattnite approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@mattnite mattnite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! beautiful

@mattnite mattnite dismissed github-actions[bot]’s stale review December 30, 2025 17:23

False positives, will fix these ones soon

@mattnite mattnite merged commit fa22dd5 into ZigEmbeddedGroup:main Dec 30, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattnite mattnite mattnite approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mathk @mattnite