CQL Heuristics Calculator#1620
Open
gonzalotguerrero wants to merge 14 commits into
Open
Conversation
jgaleotti
requested changes
Jul 8, 2026
|
|
||
| import java.util.*; | ||
|
|
||
| public class CassandraHeuristicsCalculator { |
|
|
||
| private final CassandraOperationEvaluator evaluator = new CassandraOperationEvaluator(); | ||
|
|
||
| public double computeDistance(String cqlQuery, Iterable<Map<String, Object>> allRows) { |
Collaborator
There was a problem hiding this comment.
add an abstraction for allRows.
|
|
||
| private enum ComparisonType { EQUALS, GT, GTE, LT, LTE } | ||
|
|
||
| public Truthness evaluate(CqlQueryOperation op, Map<String, Object> row) { |
|
|
||
| import static org.evomaster.client.java.controller.cassandra.CassandraHeuristicsCalculator.*; | ||
|
|
||
| public class CassandraOperationEvaluator { |
| return any(op.getValue(), toElementList(rawCol)); | ||
| } | ||
|
|
||
| private Truthness evaluateContainsKey(ContainsKeyOperation<?> op, Map<String, Object> row) { |
|
|
||
| public Truthness evaluate(CqlQueryOperation op, Map<String, Object> row) { | ||
| if (op instanceof AndOperation) | ||
| return evaluateAnd((AndOperation) op, row); |
Collaborator
There was a problem hiding this comment.
add {...} for each if. Avoid one if-liners.
|
|
||
| private static String normalizeColumnName(String name) { | ||
| if (name == null) return null; | ||
| if (name.startsWith("\"") && name.endsWith("\"")) { |
Collaborator
There was a problem hiding this comment.
replace " with constant value
| return Collections.emptyList(); | ||
| } | ||
|
|
||
| private static String normalizeColumnName(String name) { |
Collaborator
There was a problem hiding this comment.
add Javadoc explaining what normalization means for a column name
| this.nanos = nanos; | ||
| } | ||
|
|
||
| public static CqlDurationLiteral parse(String text) { |
Collaborator
There was a problem hiding this comment.
Move this code to a specific parser for this format.
| ); | ||
| } | ||
|
|
||
| public static Truthness getStringEqualityTruthness(String a, String b) { |
Collaborator
There was a problem hiding this comment.
This method seems to be a duplicate of SqlExpressionEvaluator.getEqualityTruthness(). Please check if this is indeed a duplicate. If it is, refactor SqlExpressionEvaluator.getEqualityTruthness() to use this method. Also add a Javadoc to explain what this method does.
Collaborator
Author
There was a problem hiding this comment.
It was indeed a duplicate! Now both evaluators use this method
- Small refactorings to follow dev guidelines - Refactor parsing of Duration literals and reorganise packages - Unify distance calculation for strings - Refactor operation evaluator - Add javadoc for calculator and CassandraRow abstraction
- More refactorings in parser utils - Add missing docs in parser utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CassandraHeuristicsCalculator/CassandraOperationEvaluator to compute a distance heuristic for CQL WHERE clauses
Distance calculation for each operator/data type follows the spec from this document