feat: enhance Zsh completion with menu selection#104
Merged
marcossevilla merged 6 commits intoVeryGoodOpenSource:mainfrom Oct 23, 2025
Merged
feat: enhance Zsh completion with menu selection#104marcossevilla merged 6 commits intoVeryGoodOpenSource:mainfrom
marcossevilla merged 6 commits intoVeryGoodOpenSource:mainfrom
Conversation
Member
|
/windsurf-review |
marcossevilla
previously approved these changes
Jul 8, 2025
omartinma
previously approved these changes
Jul 9, 2025
omartinma
left a comment
omartinma
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution @moshe5745 ⭐️
Member
|
hey @moshe5745, finally workflows are running, but seems to need an update on the tests too... let me know if you can take this, otherwise I can take a look, thanks again for your contribution! |
Contributor
Author
|
@marcossevilla Hey |
moshe5745
dismissed stale reviews from omartinma and marcossevilla
via
8cf2190
Contributor
Author
|
@marcossevilla Done |
Member
|
hey @moshe5745, thanks! seems like a test still failing due to formatting |
Contributor
Author
|
@marcossevilla Fixed |
marcossevilla
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This pull request enhances Zsh completion support by adding interactive menu selection and colored completion lists. Specifically, it introduces two
zstyleconfigurations:zstyle ':completion:*' menu yes select: Enables a menu-style completion interface in Zsh, allowing users to navigate options with arrow keys.zstyle ':completion:*' list-colors '': Adds color highlighting to completion suggestions for better visibility.Type of Change