Update value as empty string for OSD Icon path prefixUrl #1819
Open
HussainVAM wants to merge 1 commit into
Open
Update value as empty string for OSD Icon path prefixUrl #1819HussainVAM wants to merge 1 commit into
HussainVAM wants to merge 1 commit into
Conversation
…ontrol icons images
demiankatz
approved these changes
Jul 14, 2026
demiankatz
left a comment
demiankatz
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me, and tests are passing!
@jamesmisson, do you want to look at this further before it is merged?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where control icons in OSD Center panel were using a url prefix path of '/images/' on a base64 encoded transparent pixel causing a 404 error on control icon image tags.
Described in this issue here https://github.com/UniversalViewer/universalviewer/issues/17893
#17893
OSD docs for prefixUrl here https://openseadragon.github.io/docs/openseadragon.js.html#:~:text=Finally%20the%0A%20%20*%20%20%20%20%20image,through%20this%20setting
Bug seamed to appear after OSD v6 upgrade where this value was changed from null to undefined triggering the default value to be used. 45d8b9c#diff-9a1d014d237071dac5bf1e798e67c9c2bcda2060d8be4ee978a87e0a68f9a954R283