Add labels to gallery thumbnail size controls#1775
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@whitewooood is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks for your contribution, @whitewooood -- I took a quick look and have a question and suggestion below.
| "$shareLink": "Dolen i'r dudalen hon", | ||
| "$shareInstructions": "Er mwyn rhannu'r eitem hon, cop\u00efwch y URL isod.", | ||
| "$size": "Maint:", | ||
| "$decreaseThumbnailSize": "Lleihau maint bawdluniau", |
There was a problem hiding this comment.
Where/how did you source your non-English translations? Do we need to have our translation team review them for accuracy?
There was a problem hiding this comment.
I've reviewed the cy-GB translations and am happy that they are correct @demiankatz @erinburnand @LanieOkorodudu .
There was a problem hiding this comment.
French translations have been approved @demiankatz @LanieOkorodudu
There was a problem hiding this comment.
Polish translations also reviewed and approved @demiankatz @LanieOkorodudu
There was a problem hiding this comment.
If I'm keeping track correctly, that just leaves Swedish in need of approval -- is there someone working on that?
There was a problem hiding this comment.
It might be worth asking the SNA team to take a look if they have the time.
There was a problem hiding this comment.
I tagged Linea in the Slack message, I assume she hasn't had time yet?
|
Thanks for the review. I pushed an update using more specific content keys: For the non-English strings, I added direct equivalents so the new labels resolve in the existing locale files. They have not gone through a separate translation-team review, so adjustments from the translation workflow would be welcome. |
|
Thanks, @whitewooood, I have put this in the "in testing" column of the Community Board so we can discuss it at a future Community Call and figure out the best way to get all the translations reviewed. |
|
@demiankatz, I tested this and I can confirm the |
|
Thanks, @LanieOkorodudu, I posted on the |
Summary
Fixes #1488.
Validation