-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add breadcrumbs to navigation #7995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
9942950
feat(layout): relocate title into scrollable region
eliandoran d02ec47
feat(breadcrumb): get breadcrumb to render
eliandoran 43ceb19
feat(breadcrumb): hide last note
eliandoran 6e29fe8
feat(breadcrumb): hide preview
eliandoran 5f215b1
feat(breadcrumb): start implementing interactive breadcrumbs
eliandoran a02235f
feat(breadcrumb): set up dropdown
eliandoran c428577
feat(breadcrumb): basic navigation in separator
eliandoran adc356e
fix(breadcrumb): navigation on first level not working
eliandoran bedca9f
feat(breadcrumb): hide root icon
eliandoran c5c4ecd
feat(breadcrumb): show current item
eliandoran 200fd76
feat(breadcrumb): display a checkbox for the current note
eliandoran 223ba46
fix(breadcrumb): breadcrumb shown if there are no children
eliandoran 1e5fcf6
feat(breadcrumb): show root title if it's the one active
eliandoran 1146777
feat(breadcrumb): basic overflow support
eliandoran 3fe45db
feat(breadcrumb): improve overflow support
eliandoran 70ded4c
chore(breadcrumb): use bold for highlighting active entry
eliandoran 4cfa403
feat(breadcrumb): apply ellipsis to dropdown
eliandoran eca2116
feat(breadcrumb): make the root note clickable
eliandoran a365814
feat(breadcrumb): improve overflow slightly
eliandoran b16893c
feat(breadcrumb): collapse items if the list is too big
eliandoran ef3cbca
refactor(breadcrumb): fix eslint issues
eliandoran d15b5f8
style(next): basic styling of ribbon as a floating toolbar
eliandoran fcf51ec
chore(eslint): apply to .tsx as well
eliandoran 05679f7
feat(ribbon): prototype sticky ribbon
eliandoran 608ab53
chore(ribbon): reduce note title padding
eliandoran 5973e5c
chore(ribbon): remove label for the root entirely
eliandoran 6fac947
chore(ribbon): address requested changes
eliandoran 7377e4e
chore(ribbon): improve paddings slightly
eliandoran 6b059a9
feat(ribbon): context menu for root item
eliandoran 0805e07
feat(ribbon): basic implementation for scroll pinning
eliandoran 474228b
style(client): remove bottom border & box-shadow for content header
eliandoran 7fc3d41
fix(client): 1px scroll in full-height note
eliandoran d5d2815
fix(client/floating_buttons): clipped by ribbon
eliandoran 5770222
fix(client/floating_buttons): clipped by floating content header
eliandoran bfcf85e
fix(client/layout): content header height not properly resized when s…
eliandoran 895e9b8
chore(client/layout): reduce transitions
eliandoran 8df5a01
fix(ribbon): note buttons cut off
eliandoran fb6c827
chore(ribbon): remove top transition completely
eliandoran 3514e3d
fix(floating_buttons): wrong position when at the top of the note
eliandoran 1998080
style(ribbon): fix some alignment issues & decrease button size
eliandoran 72b0d03
chore(layout): remove some title margins
eliandoran 658b699
fix(collections/geomap): fake floating buttons mispositioned
eliandoran 4d75221
chore(breadcrumbs): address requested changes
eliandoran 2ff8762
chore(client): fix typecheck
eliandoran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| .breadcrumb-row { | ||
| position: relative; | ||
| } | ||
|
|
||
| .component.breadcrumb { | ||
| contain: none; | ||
| display: flex; | ||
| margin: 0; | ||
| align-items: center; | ||
| font-size: 0.9em; | ||
| gap: 0.25em; | ||
| flex-wrap: nowrap; | ||
| overflow: hidden; | ||
| max-width: 85%; | ||
|
|
||
| > span, | ||
| > span > span { | ||
| display: flex; | ||
| align-items: center; | ||
| min-width: 0; | ||
|
|
||
| a { | ||
| color: inherit; | ||
| text-decoration: none; | ||
| min-width: 0; | ||
| max-width: 150px; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| overflow: hidden; | ||
| display: block; | ||
| flex-shrink: 2; | ||
| } | ||
| } | ||
|
|
||
| > span:last-of-type a { | ||
| max-width: 300px; | ||
| flex-shrink: 1; | ||
| } | ||
|
|
||
| ul { | ||
| flex-direction: column; | ||
| list-style-type: none; | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| .dropdown-item span, | ||
| .dropdown-item strong { | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| overflow: hidden; | ||
| display: block; | ||
| max-width: 300px; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.