refactor(baseheightmap): Extract scorch rendering from BaseHeightMap into new W3DScorch - #3017
Open
stephanmeesters wants to merge 1 commit into
Open
refactor(baseheightmap): Extract scorch rendering from BaseHeightMap into new W3DScorch#3017stephanmeesters wants to merge 1 commit into
stephanmeesters wants to merge 1 commit into
Conversation
…into new W3DScorch
stephanmeesters
added
the
Refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W3DScorchDO_SCORCHhave mostly been removedDO_SCORCHbefore didn't compile but this has been fixed. Scorches are now disabled usingW3DScorchDummywhen usingDO_SCORCH=0W3DScorchDummycould be used in headless mode (not part of this PR)N.B. some code was in
DO_SCORCHthat didn't actually belong inside the macro, for exampleReal m_curImpassableSlope;