unify(particlesys): Merge and move W3DParticleSys to core#3014
unify(particlesys): Merge and move W3DParticleSys to core#3014stephanmeesters wants to merge 2 commits into
Conversation
| for (Particle *p = sys->getFirstParticle(); p; p = p->m_systemNext) | ||
| { | ||
| // do not attempt to render totally invisible particles | ||
| if (p->isInvisible()) |
There was a problem hiding this comment.
There have been bugs reported in ZH where invisible particles are rendered. Could this be a cause? Wouldn't it therefore be better to merge this Generals code to Zero Hour instead.
There was a problem hiding this comment.
Do you mean the recent report where particles were being created under the terrain? Because this function wouldn't catch those. Didn't find any issues related to invisible particles in the list, would be interested to investigate
There was a problem hiding this comment.
Yes I meant that report.
The code in Generals makes sense without context. So the question is why it was removed in ZH and whether that was correct or a mistake.
There was a problem hiding this comment.
I suspect this was removed because it was deemed unnecessary when invisible particles will be deleted in the logic update.
You could put a breakpoint here and see if that is ever called, or how much, and see if it carries any merit.
It probably does not.
There was a problem hiding this comment.
Tested with a breakpoint before in ZH, now also tested with a breakpoint in vGenerals, did not see it get triggered.
xezon
added
Gen
88ef5a0 to
c5cacdf
Compare
3 participants
Merge by rebase
This merges and moves
W3DParticleSys.handW3DParticleSys.cpp.Generals gets:
TheSmudgeManageris non-null but we don't expect to see any smudges in the data)TheSnowManageris null)